feat: support FormData
#286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
climba03003
commented
Apr 6, 2024
Signed-off-by: KaKa <23028015+climba03003@users.noreply.github.com>
mcollina
requested changes
Apr 8, 2024
Member
mcollina
left a comment
There was a problem hiding this comment.
Amazing work! Can you add a test for Node v14 and v16?
climba03003
commented
Apr 8, 2024
climba03003
commented
Apr 8, 2024
Comment on lines
+2105
to
+2110
| // supports >= node@18 | ||
| runFormDataUnitTest('native', { FormData: globalThis.FormData, Blob: globalThis.Blob }) | ||
| // supports >= node@16 | ||
| runFormDataUnitTest('undici', { FormData: require('undici').FormData, Blob: require('node:buffer').Blob }) | ||
| // supports >= node@14 | ||
| runFormDataUnitTest('formdata-node', { FormData: require('formdata-node').FormData, Blob: require('formdata-node').Blob }) |
Member
Author
There was a problem hiding this comment.
Coverage should be fine for all supported node version.
undici only supports FormData higher than node@16.
So, we need formdata-node for node@14.
It also show that we are not limited to undici implementation only, but support all spec compliance FormData
metcoder95
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support FormData and provide the
Content-Typeheader automatically.Closes fastify/fastify-multipart#516
Closes fastify/help#1017
Checklist
npm run testandnpm run benchmarkand the Code of conduct