types: added missing iso time types#277
Merged
Fdawgs merged 3 commits intofastify:mainfrom Aug 14, 2025
Merged
Conversation
2 tasks
There was a problem hiding this comment.
Pull Request Overview
Adds TypeScript support for two missing ISO format types (iso-time and iso-date-time) to the FluentJSONSchema library. This addresses issue #267 by implementing complete TypeScript definitions and test coverage for these ISO datetime formats.
- Added TypeScript type definitions for
iso-timeandiso-date-timestring formats - Extended test coverage with unit tests and TypeScript validation tests
- Updated API documentation to include the new ISO format types
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| types/FluentJSONSchema.test-d.ts | Adds TypeScript test case validating the new ISO format types |
| src/StringSchema.test.js | Adds unit test for the ISO_TIME format validation |
| docs/API.md | Updates documentation to include ISO_TIME and ISO_DATE_TIME formats |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Fdawgs
approved these changes
Aug 14, 2025
Member
|
Related to #254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing TypeScript support for iso-time and iso-date-time formats
Adding documentation for both formats in the API reference
Providing dedicated unit and TypeScript test coverage
fixes: #267
Checklist
npm run testandnpm run benchmarkand the Code of conduct