Use standard and @fastify/pre-commit#190
Merged
aboutlo merged 6 commits intofastify:masterfrom Oct 1, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 2948849632Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
mcollina
requested changes
Aug 29, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
I'm generically -1 in changing the formatting of some code.
Collaborator
|
I have no strong opinion but it's just cosmetic :) |
Contributor
Author
|
@aboutlo |
Eomm
approved these changes
Sep 3, 2022
Member
Eomm
left a comment
There was a problem hiding this comment.
I'm +1 to ease the maintenance across repos by adopting the same structure.
We are free to experiment on personal repos tho
zrosenbauer
approved these changes
Sep 19, 2022
Contributor
Author
Collaborator
|
no strong opinion, but given others signalled in favor and we can standardise towards what other repo do I will merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct