Skip to content

Fix: throw on root-level required#134

Merged
aboutlo merged 2 commits intofastify:masterfrom
erfanium:fix-#132
Jun 18, 2021
Merged

Fix: throw on root-level required#134
aboutlo merged 2 commits intofastify:masterfrom
erfanium:fix-#132

Conversation

@erfanium
Copy link
Contributor

@erfanium erfanium commented Jun 2, 2021 •
edited
Loading

Fixes #132
I added isRoot option for valueOf method, which is true by default and false for internal calls.
I didn't update .d.ts files, should I do?

Checklist

mcollina
mcollina reviewed Jun 2, 2021
View reviewed changes
@coveralls
Copy link

coveralls commented Jun 3, 2021

Pull Request Test Coverage Report for Build 900830188

  • 0 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.559%
Totals Coverage Status
Change from base Build 892669691: 0.005%
Covered Lines: 410
Relevant Lines: 410
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 900830188

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.559%
Totals Coverage Status
Change from base Build 892669691: 0.005%
Covered Lines: 410
Relevant Lines: 410
💛 - Coveralls

aboutlo
aboutlo reviewed Jun 3, 2021
View reviewed changes
@aboutlo
Copy link
Collaborator

aboutlo commented Jun 3, 2021

tks @erfanium! LGTM

@erfanium erfanium requested review from aboutlo and mcollina June 3, 2021 16:30
mcollina
mcollina approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit 309de72 into fastify:master Jun 18, 2021
@erfanium erfanium deleted the fix-#132 branch June 18, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@aboutlo aboutlo Awaiting requested review from aboutlo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Root level required creates invalid schema

4 participants

@erfanium @coveralls @aboutlo @mcollina