Skip to content

ci: remove redundant conditional#118

Merged
aboutlo merged 1 commit intofastify:masterfrom
Fdawgs:patch-1
Apr 9, 2021
Merged

ci: remove redundant conditional#118
aboutlo merged 1 commit intofastify:masterfrom
Fdawgs:patch-1

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 7, 2021

Checklist

@coveralls
Copy link

coveralls commented Apr 7, 2021

Pull Request Test Coverage Report for Build 726917670

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.547%

Totals Coverage Status
Change from base Build 707449657: 0.0%
Covered Lines: 402
Relevant Lines: 402

💛 - Coveralls

runs-on: ubuntu-latest
steps:
- uses: fastify/github-action-merge-dependabot@v2.0.0
if: ${{ github.actor == 'dependabot[bot]' && github.event_name == 'pull_request' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Fdawgs If I remember correctly we added this because we were not running the checks on the pull_request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not needde anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aboutlo, as @mcollina said, with v2.0.0 of the action it handles all this for us. So the 'if' conditional is no longer needed.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit 714ff9b into fastify:master Apr 9, 2021
@Fdawgs Fdawgs deleted the patch-1 branch April 9, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants