Can you please bump the dependency to Fastify v2.4.1? That has the fix you need.

OK, I’ll do ASAP!

with this setup:

fastify.register(require('./'), {
  handle,
  options: { maxPayload: 1048576 }
})

fastify.get('/', { websocket: true }, (connection, req) => {
  connection.socket.on('message', message => {
    // message === 'hi from client'
    connection.socket.send('hi from server')
  })
})

Should we throw an error?

I don't understand your point. Can you elaborate, please?

I don't understand your point. Can you elaborate, please?

Yeah sorry.

In that case, I set up a global handler and a route handler at the same endpoint.

The server starts correctly and when I connect to it with const ws = new WebSocket('ws://localhost:3000') (also with the final slash) I will get a hi from server response.

So I'm wondering if it the case to throw an "already declared" error. WDYT?

WDYT

OK. I think there is a misconception about "global" handler: it is a handler that is called when no more specific routes are defined. If you don't defined it, the plugin provides the "404 WS" response for you. I think that what you did is the correct behavior.

I read better the docs and it is written, thank you for the explanation.

As you pointed I suggested the spaces

Great feature 👍 Thank you

Nice! ☺️

Snap, there is a conflict in README. @Eomm could you reslove it? Just use your suggestion.

Any news on merging this?

Releasing later today or at least tomorrow if anybody can't do it before 👍🏼