Skip to content

docs(readme): correct TypeBox types in example#179

Merged
mcollina merged 1 commit intofastify:mainfrom
jpenna:patch-1
Jan 12, 2025
Merged

docs(readme): correct TypeBox types in example#179
mcollina merged 1 commit intofastify:mainfrom
jpenna:patch-1

Conversation

@jpenna
Copy link
Contributor

@jpenna jpenna commented Oct 18, 2024

  • Fixed FastifyReplyTypebox that had the incorrect order of generic types
  • Added FastifyTypeBox as the Fastify instance with TypeBox as the type provider
  • Renamed ...Typebox -> ...TypeBox (the lib's casing)

Checklist

- Fixed `FastifyReplyTypebox` that had the incorrect order of generic types
- Added `FastifyTypeBox` as the Fastify instance with TypeBox as the type provider
- Renamed `...Typebox` -> `...TypeBox` (the lib's casing)

Signed-off-by: Juliano Penna <julianopenna@gmail.com>
@Fdawgs Fdawgs requested a review from Copilot November 20, 2024 10:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@Fdawgs Fdawgs changed the title Update README.md - Correct TypeBox types in example docs(readme): correct TypeBox types in example Dec 3, 2024
@Ali-Aref
Copy link

Ali-Aref commented Jan 6, 2025

please merge this I almost struggle a lot with this :) and finally solved and when I wanted to make PR I found this.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!!

@mcollina mcollina merged commit 0a46cd1 into fastify:main Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants