Change onresponse contract to allow request, reply, and res.#43
Merged
mcollina merged 2 commits intofastify:masterfrom Feb 10, 2019
Merged
Change onresponse contract to allow request, reply, and res.#43mcollina merged 2 commits intofastify:masterfrom
mcollina merged 2 commits intofastify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to allow
replyOptionsto work infastify-http-proxy. The PR in question is here: fastify/fastify-http-proxy#34The only way that I am able to get this to work is to change the contract in
fastify-reply-fromso thatrequest, reply, resare all available. If this is acceptable let me know and I will update the other reply with the appropriate test.Thanks again!