Decorate reply with nextRenderError #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy to Next.js app.renderError - this method will render an appropriate error page based on the response status code.
2 tasks
stefee
commented
Dec 15, 2021
Comment on lines
+107
to
+118
| const reply = this | ||
| const { request } = reply | ||
|
|
||
| // set custom headers as next will finish the request | ||
| for (const [headerName, headerValue] of Object.entries(reply.getHeaders())) { | ||
| // Fastify sets content-length to `undefined` for error handlers, which is an invalid value | ||
| if (headerName === 'content-length' && headerValue === undefined) { | ||
| continue | ||
| } | ||
|
|
||
| reply.raw.setHeader(headerName, headerValue) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
copied from render above
stefee
commented
Dec 15, 2021
mcollina
reviewed
Dec 15, 2021
Member
mcollina
left a comment
There was a problem hiding this comment.
Can you please add a unit test?
Contributor
Author
|
@mcollina |
Contributor
Author
|
I am unsure if the CI failures are a result of the changes. |
Member
|
It might be, it seems code coverage got reduced. |
Contributor
Author
|
Ah yes, I will look into that. |
Contributor
Author
|
This should be ready for landing :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435
Proxy to Next.js
app.renderError.The source code for
app.renderErrorat time of writing can be found here:app.renderError(public)app.renderErrorToResponse(private)This method will render an appropriate error page based on the response status code - the pathname does not affect the page rendering.
The page that will be rendered by this method can include:
/pages/_error.js/pages/404.js/pages/500.jsChecklist
npm run testandnpm run benchmarkand the Code of conduct