Conversation
metcoder95
approved these changes
Mar 12, 2025
Member
|
Needs a unit test? |
jsumners
reviewed
Mar 12, 2025
|
|
||
| ``` | ||
| createError(code, message [, statusCode [, Base]]) | ||
| createError(code, message [, statusCode [, Base [, captureStackTrace]]]) |
Member
There was a problem hiding this comment.
This is a great example of why I think
#117 (comment) is needed.
Member
Author
There was a problem hiding this comment.
I agree that at this point it's too many parameters
I was thinking of using this approach to cut a non-breaking release and then changing the signature as a major
That way we can have some time to refactor other codebases
Member
There was a problem hiding this comment.
I agree to make it as two step, release as feature then refactor the params.
Fdawgs
approved these changes
Mar 12, 2025
climba03003
approved these changes
Mar 12, 2025
Member
Author
|
I'll cut a release |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From fastify/fastify#5925
This is to gather feedback
It allows us to have a centralized way to disable stack traces for Fastify errors
The global
createError.captureStackTraceproperty can be used to disable stack generation for FastifyErrors when the parameter is not specified