fix(types): make definitions nodenext compatible#224
Merged
Uzlopak merged 5 commits intofastify:masterfrom Oct 24, 2022
SuperchupuDev:patch-1
Merged
fix(types): make definitions nodenext compatible#224Uzlopak merged 5 commits intofastify:masterfrom SuperchupuDev:patch-1
nodenext compatible#224Uzlopak merged 5 commits intofastify:masterfrom
SuperchupuDev:patch-1
Conversation
Contributor
|
Do we have a typing test for this? |
Contributor
|
CI is failing. |
climba03003
requested changes
Sep 23, 2022
Member
There was a problem hiding this comment.
It is not a proper fix and it will just break the existing user.
The proper fix should follow fastify/fastify-cookie#184 or fastify/fastify-static#311
And most likely it requires to fix in all modules including core.
nodenext compatible
Contributor
Author
|
I tried fixing the tests but the error messages are really complex for a person that doesn't know much about fastify's internals. Adding |
Contributor
|
I fixed the typings. |
climba03003
reviewed
Oct 21, 2022
Co-authored-by: KaKa <climba03003@gmail.com>
fox1t
requested changes
Oct 24, 2022
fox1t
approved these changes
Oct 24, 2022
Uzlopak
reviewed
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223
Checklist
npm run testandnpm run benchmarkand the Code of conduct