chore: move from tap to node:test#306
Merged
gurgunday merged 3 commits intofastify:masterfrom Dec 10, 2024
Merged
Conversation
dancastillo
reviewed
Nov 7, 2024
Member
There was a problem hiding this comment.
Can you use test context so assert.strictEqual -> t.assert.strictEqual
Member
There was a problem hiding this comment.
Can you add back in t.plan. The test will end before assertions are compelete i believe
Then for the tests with callbacks update to
test('test name here', (t, done) => {
// set up and test code
done() // call after last assertion
})
jsumners
requested changes
Nov 7, 2024
Member
jsumners
left a comment
There was a problem hiding this comment.
Please address @dancastillo's concern.
Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
Contributor
|
Fixed the tests... PTAL. |
gurgunday
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are related to the issue fastify/fastify#5555
Changed signer.test.js and cookie.test.js to use node:test instead of tap.
Checklist
npm run testand the Code of conduct