export integrated cookie functionality#263
Merged
Conversation
mcollina
requested changes
Nov 15, 2023
mcollina
requested changes
Nov 15, 2023
Contributor
Author
|
@mcollina PTAL |
Member
|
Plase require the entrypoint file in . |
jsumners
reviewed
Nov 15, 2023
Member
jsumners
left a comment
There was a problem hiding this comment.
If the other module is going to use @fastify/cookie to manage cookies, why do we need to export the underlying tooling?
Contributor
Author
|
@mcollina |
gurgunday
approved these changes
Nov 20, 2023
mcollina
requested changes
Nov 20, 2023
Member
mcollina
left a comment
There was a problem hiding this comment.
Can you document it in the README?
Fdawgs
reviewed
Nov 25, 2023
| you should register it prior to any other `onRequest` hooks that will depend | ||
| upon this plugin's actions. | ||
|
|
||
| It is also possible to import the low-level cookie parsing and serialization functions. |
Member
There was a problem hiding this comment.
Maybe add a link here to the header section regarding the import?
Fdawgs
approved these changes
Nov 25, 2023
Contributor
Author
|
@mcollina PTAL @gurgunday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can use it in fastify/secure-session and co instead of the cookie package.
Checklist
npm run testandnpm run benchmarkand the Code of conduct