perf: don't initialize req.cookies before checking the header#248
Merged
mcollina merged 1 commit intofastify:masterfrom Aug 17, 2023
Merged
perf: don't initialize req.cookies before checking the header#248mcollina merged 1 commit intofastify:masterfrom
mcollina merged 1 commit intofastify:masterfrom
Conversation
Member
|
Good spot! |
renovate bot
referenced
this pull request
in specfy/specfy
Nov 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cookie](https://togithub.com/fastify/fastify-cookie) | [`9.0.4` -> `9.2.0`](https://renovatebot.com/diffs/npm/@fastify%2fcookie/9.0.4/9.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cookie (@​fastify/cookie)</summary> ### [`v9.2.0`](https://togithub.com/fastify/fastify-cookie/releases/tag/v9.2.0) [Compare Source](https://togithub.com/fastify/fastify-cookie/compare/v9.1.0...v9.2.0) #### What's Changed - chore: add `.gitattributes` file by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-cookie/pull/255](https://togithub.com/fastify/fastify-cookie/pull/255) - refactor(signer): add `u` unicode flag to regex by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-cookie/pull/256](https://togithub.com/fastify/fastify-cookie/pull/256) - chore(deps-dev): bump sinon from 16.1.3 to 17.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-cookie/pull/257](https://togithub.com/fastify/fastify-cookie/pull/257) - chore(package): explicitly declare js module type by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-cookie/pull/258](https://togithub.com/fastify/fastify-cookie/pull/258) - refactor(plugin): replace `typeof` undefined check by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-cookie/pull/259](https://togithub.com/fastify/fastify-cookie/pull/259) - Go back to use our own cookie implementation by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify-cookie/pull/260](https://togithub.com/fastify/fastify-cookie/pull/260) - feat: add partitioned by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-cookie/pull/261](https://togithub.com/fastify/fastify-cookie/pull/261) **Full Changelog**: fastify/fastify-cookie@v9.1.0...v9.2.0 ### [`v9.1.0`](https://togithub.com/fastify/fastify-cookie/releases/tag/v9.1.0) [Compare Source](https://togithub.com/fastify/fastify-cookie/compare/v9.0.4...v9.1.0) #### What's Changed - perf: don't initialize req.cookies before checking the header by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-cookie/pull/248](https://togithub.com/fastify/fastify-cookie/pull/248) - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-cookie/pull/249](https://togithub.com/fastify/fastify-cookie/pull/249) - perf: use `node:` prefix for builtins by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-cookie/pull/250](https://togithub.com/fastify/fastify-cookie/pull/250) - chore(deps-dev): bump sinon from 15.2.0 to 16.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-cookie/pull/252](https://togithub.com/fastify/fastify-cookie/pull/252) - use named exports by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-cookie/pull/254](https://togithub.com/fastify/fastify-cookie/pull/254) **Full Changelog**: fastify/fastify-cookie@v9.0.4...v9.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change where
request.cookiesis no longer initialized (NEW, L56) before checking if the cookie header is set. Saves us an empty object creation if the header existsChecklist
npm run testandnpm run benchmarkand the Code of conduct