Fixes plugin.autoConfig on export default#62
Merged
Conversation
Member
|
@Ethan-Arrowood can you please check this? |
Member
Author
|
@Ethan-Arrowood you can find the motivations of this PR here: #61 |
Eomm
approved these changes
Feb 8, 2020
Member
|
Sorry I missed this — will review tomorrow 😁 |
Ethan-Arrowood
approved these changes
Feb 10, 2020
Ethan-Arrowood
left a comment
Member
There was a problem hiding this comment.
This looks good to me. As I understand it this code satisfies multiple export syntax for plugins and thats a good thing in regards to better developer experience. Good Work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61
Checklist
npm run test