fix: restore trustProxy function for number and string types, add null check for socketAddr#6613
Merged
Merged
Conversation
…l check for socketAddr Fixes: fastify#6606 The regression was introduced when the proxy trust function was changed to check for null addresses. This caused issues with IISNode on Windows where socket.remoteAddress may be undefined/null with enableXFF='true'. The fix removes the 'a != null' check from number and string trust functions, and adds explicit null checks in host and protocol getters.
Tony133
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6606
Description
The regression was introduced when the proxy trust function was changed to check for null addresses. This caused issues with IISNode on Windows where may be undefined/null with .
Changes
a != nullcheck from number and string trust proxy functionstrustProxy: 1with undefined and null socket remoteAddressTesting
All existing tests pass, plus new tests for the IISNode scenario.