docs(security): clarify insecureHTTPParser threat model scope#6533
Merged
docs(security): clarify insecureHTTPParser threat model scope#6533
Conversation
jsumners
approved these changes
Feb 25, 2026
jsumners
reviewed
Feb 25, 2026
Member
jsumners
left a comment
There was a problem hiding this comment.
Mind blowing that this has to be spelled out. It's in the name: insecureHTTP.
504dcc5 to
ac11a27
Compare
Member
Author
|
@jsumners @RafaelGSS can I have a fresh lgtm? |
Fdawgs
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SECURITY.mdthat Fastify's threat model assumes Node.js runs withinsecureHTTPParser: falseinsecureHTTPParser: trueas out of scopeTesting