fix: remove format placeholder from FST_ERR_CTP_INVALID_MEDIA_TYPE message#6528
Merged
mcollina merged 1 commit intofastify:mainfrom Feb 28, 2026
Merged
Conversation
super-mcgin
commented
Feb 23, 2026
jsumners
reviewed
Feb 23, 2026
…ssage The error message template 'Unsupported Media Type: %s' produced the literal string '%s' when instantiated without arguments, as in lib/handle-request.js. Rather than reflecting the raw content-type header value back to the client (which would expose unsanitized user input in error responses and logs), the template is changed to the static message 'Unsupported Media Type'. This is a minor breaking change for consumers that match on the exact error message string. The error code 'FST_ERR_CTP_INVALID_MEDIA_TYPE' and HTTP status 415 are unchanged and should be used for programmatic error handling instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
571297e to
7e26e1b
Compare
Contributor
Author
|
@jsumners I've updated this so it never echoes the recevied value now. Technically this now would be considered a breaking change but I wouldn't think it warrants a major version update given it's only the message Another alternative would be to simply pass a fixed string or an empty string to the original attempt at fixing it, which would retain the existing behaviour |
jsumners
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'Unsupported Media Type: %s'produced the literal string%swhen instantiated without arguments (as inlib/handle-request.js).content-typeheader back to the client (which would expose unsanitized user input in error responses and logs), the template is changed to the static message'Unsupported Media Type'.lib/handle-request.jsandlib/content-type-parser.js) now instantiate the error with no arguments.Breaking change
This is a minor breaking change for consumers that match on the exact
error.messagestring (previously'Unsupported Media Type: <content-type>', now'Unsupported Media Type'). The error codeFST_ERR_CTP_INVALID_MEDIA_TYPEand HTTP status415are unchanged and should be used for programmatic error handling instead.Test plan
'Unsupported Media Type'(no%splaceholder)🤖 Generated with Claude Code