Merged
Conversation
Member
Author
|
@Eomm @jsumners @RafaelGSS @climba03003 I iterated a bit with Claude on creating this document. Wdyt? |
Adds a comprehensive threat model section to SECURITY.md, rooted in and extending the Node.js threat model. This clarifies: - What Fastify trusts (application code, schemas, configuration) - What Fastify does NOT trust (network input from clients) - What constitutes a security vulnerability vs. application bugs - Built-in security protections and their defaults - Trust boundaries with visual diagram - Request lifecycle security intervention points - Encapsulation security model This also addresses the OpenSSF CII silver badge gap for documenting "what the user can and cannot expect in terms of security". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
4252d66 to
caa9970
Compare
Member
How much of this is your own work? I just reviewed the Pino one and am unclear how much of that one was llm output, but it felt a lot. |
3518114 to
c1d36b5
Compare
Adds a concise threat model section extending the Node.js threat model. Clarifies what Fastify trusts vs. doesn't trust, and what constitutes a security vulnerability vs. application-level issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
c1d36b5 to
aa3d0ec
Compare
Member
Author
|
@jsumners updated and simplified |
jsumners
approved these changes
Dec 6, 2025
RafaelGSS
approved these changes
Dec 7, 2025
Member
RafaelGSS
left a comment
There was a problem hiding this comment.
LGTM. I can iterate on that later with some clear examples of non-vuln.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a concise threat model section to
SECURITY.md, extending theNode.js threat model.
Clarifies:
🤖 Generated with Claude Code