Merged
Conversation
Member
|
I wonder why these tests are commented @fastify/core? |
jean-michelet
approved these changes
Oct 5, 2025
Uzlopak
requested changes
Oct 5, 2025
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
The whole file can be deleted. The tests are also existing in serialize-response.test.js
https://github.com/fastify/fastify/blob/main/test/serialize-response.test.js
gurgunday
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct
Since the v5 integration, this piece of code has been commented. I think it's time to remove it in order to do some cleanup.