ci: remove label of citgm only on pull_request.labeled, add options for workflow_dispatch#6335
Conversation
…ptions for workflow_dispatch The previous PR for citgm improved the usability, but it had a bug on when to try to remove the label.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CITGM workflow where the label removal was triggered incorrectly, and adds input options for manual workflow dispatch to improve usability.
- Fixed label removal condition to only trigger on pull_request.labeled events
- Added input parameters for node-version and operating system selection in workflow_dispatch
- Removed hard-coded matrix values in favor of input parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
.github/workflows/citgm.yml:1
- The removal of '@fastify/diagnostics-channel' from the package list appears unrelated to the stated purpose of this PR. If this package should no longer be tested, consider documenting the reason or making this change in a separate PR focused on package list maintenance.
name: CITGM
.github/workflows/citgm.yml:1
- The matrix strategy variables are being removed but their removal appears incomplete. Consider whether the entire matrix block should be removed since the strategy is no longer being used, or if these lines should be properly cleaned up as part of the refactoring.
name: CITGM
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR for citgm improved the usability, but it had a bug on when to try to remove the label.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct