Skip to content

fix: accept htab ows#6303

Merged
Eomm merged 2 commits intofastify:mainfrom
jean-michelet:fix/accept-htab-ows
Sep 24, 2025
Merged

fix: accept htab ows#6303
Eomm merged 2 commits intofastify:mainfrom
jean-michelet:fix/accept-htab-ows

Conversation

@jean-michelet
Copy link
Member

Fixes #6297

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it has to be done in fast-content-type-parse

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe I am wrong... Retracting my blocker

@Uzlopak Uzlopak dismissed their stale review August 28, 2025 08:56

maybe i am wrong, dont want to block

@jean-michelet jean-michelet requested a review from a team August 28, 2025 11:14
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jean-michelet
Copy link
Member Author

I recommend not merging before reading: discussion_r2311842747

@Eomm Eomm added the bugfix Issue or PR that should land as semver patch label Sep 3, 2025
@jean-michelet
Copy link
Member Author

I don't have voting feedback.
Maybe you should merge the PR if still ok with the changes @gurgunday.
This is basically just allowing \t as valid OWS.

Once merged, I open an issue to fix the discovered bug.

@Eomm
Copy link
Member

Eomm commented Sep 24, 2025

@jean-michelet sorry, I missed your poll

If you can fix the conflicts I will merge this PR as it is since there are no blocker
This is my position still: #6303 (comment)

We can do a followup PR to make it 100% compatible

@github-actions github-actions bot added typescript TypeScript related github actions Github actions related labels Sep 24, 2025
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 6a428d9 into fastify:main Sep 24, 2025
30 checks passed
@jean-michelet jean-michelet deleted the fix/accept-htab-ows branch September 25, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Issue or PR that should land as semver patch github actions Github actions related typescript TypeScript related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Aligning with RFC 9110

6 participants