chore: add max-len ESLint rule with 120 character limit#6221
Merged
Eomm merged 14 commits intofastify:mainfrom Oct 30, 2025
Merged
chore: add max-len ESLint rule with 120 character limit#6221Eomm merged 14 commits intofastify:mainfrom
Eomm merged 14 commits intofastify:mainfrom
Conversation
- Add max-len rule with 120 character limit as requested in fastify#6029 - Exclude TypeScript definition files from max-len rule - Add ignore options for URLs, strings, templates, regex, and comments - Resolves remaining part of fastify#6029 (line length limit) Fixes fastify#6029
mcollina
reviewed
Jun 25, 2025
Member
mcollina
left a comment
There was a problem hiding this comment.
Can you go ahead and fix the inconsistencies?
Contributor
Author
|
Done :) |
Signed-off-by: Manuel Spigolon <behemoth89@gmail.com>
jsumners
approved these changes
Jun 26, 2025
gurgunday
approved these changes
Jun 28, 2025
4 tasks
Member
|
If we don't add no-nested-ternary rule and tests are green, maybe we can merge. |
Contributor
Author
|
perfect, hoepfully will be merged |
Member
|
Fix conflicts plz |
Member
|
There are TypeScript errors. |
Contributor
|
FIxed the issues in this PR... Btw. seems to be AI slop |
Eomm
approved these changes
Oct 30, 2025
ilteoood
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR intentionally introduces 80 ESLint violations to demonstrate the current state of line length in the codebase. This is the expected behavior requested in issue #6029 to assess the impact of adding the max-len rule.
The failing tests show exactly what @Eomm wanted to evaluate: "check if adding max-len with 120 hurts the codebase or not."
Fixes #6029
Checklist
npm run testandnpm run benchmarkand the Code of conduct