style: add "no comma-dangle" rule to eslint config and remove trailing commas#6069
Merged
Eomm merged 1 commit intofastify:mainfrom Apr 24, 2025
Merged
style: add "no comma-dangle" rule to eslint config and remove trailing commas#6069Eomm merged 1 commit intofastify:mainfrom
Eomm merged 1 commit intofastify:mainfrom
Conversation
add no-comma-dangle eslint rule remove trailing commas
gurgunday
approved these changes
Apr 21, 2025
Eomm
approved these changes
Apr 24, 2025
4 tasks
This was referenced Aug 15, 2025
This was referenced Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comma-dangle" rule on eslint config filenpm run lint:fixto remove remaining trailing commasI get an error from coverage threshold on tests for
lib/server.jsbut, since it is happening onmainbranch too, I ignored the pre-commit hook. I can open a PR to add the missing test if needed.Fixes: #6029
Checklist
npm run testandnpm run benchmarkand the Code of conduct