Conversation
Member
|
I'm good with the change. Can you add a test? |
Member
Author
|
A step forward: I can replicate the error by using a single HTTP request by using this client: const http = require('http')
const postData = JSON.stringify({ test: 'me' })
const options = {
hostname: 'localhost',
port: 3000,
path: '/',
method: 'PUT',
headers: {
'Content-Type': 'application/json',
'Content-Length': Buffer.byteLength(postData),
}
}
const req = http.request(options, (res) => {
console.log('Response received')
})
// Kill the socket immediately (before sending data)
req.on('socket', (socket) => {
console.log('Destroying socket...')
setTimeout(() => {
socket.destroy()
}, 5)
})
req.on('error', (err) => {
console.error('Request error:', err)
})
req.write(postData)
req.end()I will find what we are missing.. 
|
2 tasks
climba03003
reviewed
Mar 16, 2025
gurgunday
reviewed
Mar 16, 2025
Signed-off-by: Manuel Spigolon <behemoth89@gmail.com>
metcoder95
approved these changes
Mar 20, 2025
Member
Author
|
checking the flakyness |
Member
Author
|
@mcollina would you mind testing this PR in your env since you were effected by the previous fix? |
Merged
climba03003
approved these changes
Mar 24, 2025
mcollina
approved these changes
Mar 24, 2025
Member
mcollina
left a comment
There was a problem hiding this comment.
lgtm
my regression test is passing, we can land and ship this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the discussion about this issue:
To replicate the issue:
npx autocannon -m PUT -c 1 -d 1 http://localhost:3000/ -b '{ "test": "me" }' -H "Content-Type: application/json"(it does not happen always, but 2/3 or run fails for me)From my experiment, when we resolve the thenable:
fastify/lib/reply.js
Line 473 in 30b8129
The output of this line:
console.log('fulfilled: ', this.raw.writableEnded, this.raw.destroyed, this.raw.aborted, err)is:fulfilled: true true undefined undefinedfulfilled: false true undefined Error [ERR_STREAM_PREMATURE_CLOSE]: Premature closeBy reading the comments, I see the
ERR_STREAM_PREMATURE_CLOSEerror is skipped because it is set byeosfastify/lib/reply.js
Lines 464 to 465 in 30b8129
Should we?
Checklist
npm run testandnpm run benchmarkand the Code of conduct