refactor: conditional require ajv when using custom validators/serializers#6005
Closed
spaceemotion wants to merge 1 commit intofastify:mainfrom
Closed
refactor: conditional require ajv when using custom validators/serializers#6005spaceemotion wants to merge 1 commit intofastify:mainfrom
ajv when using custom validators/serializers#6005spaceemotion wants to merge 1 commit intofastify:mainfrom
Conversation
2 tasks
ajv when using custom validators/serializers
Eomm
reviewed
Mar 8, 2025
| * Inline require to avoid hard dependency on ajv when a custom validator is used | ||
| */ | ||
| function buildDefaultValidator () { | ||
| const ValidatorSelector = require('@fastify/ajv-compiler') |
Member
There was a problem hiding this comment.
We should add a test for it. It must be a new test file and then we can inspect the require.cache: https://nodejs.org/api/modules.html#requirecache
2 tasks
Member
|
Are @spaceemotion planning to push forward this PR? |
Author
|
@Eomm thanks for picking this up - I couldn't find the time to work on this so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom validator or serializer for content, the AJV and fast-json-stringify libraries are still required by default. This makes excluding them via a build process (like
esbuild) error out.This PR moves the require() call into a function that only gets used as a fallback.
See #5507
Checklist
npm run testandnpm run benchmarkand the Code of conduct