fix: ReadableStream.locked crashes application#5920
Merged
climba03003 merged 2 commits intomainfrom Jan 3, 2025
Merged
Conversation
metcoder95
approved these changes
Jan 3, 2025
Eomm
approved these changes
Jan 3, 2025
Member
Eomm
left a comment
There was a problem hiding this comment.
Would you like to ship this fix?
Note that there is 2 versions to update:
9177df0
TBH I run a custom releasify version where:
- I add
git.add('fastify.js')at https://github.com/fastify/releasify/blob/master/lib/commands/publish.js - Skip this assert: https://github.com/fastify/releasify/blob/master/lib/commands/publish.js#L84
Then:
git clean -fx
releasify publish -s patch -n --gh-release-body -b main
Member
Author
I am willing to and trying. |
|
Thank you for putting this up! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5919
Checklist
npm run testandnpm run benchmarkand the Code of conduct