Skip to content

refactor: change var instances to const or let#5759

Merged
metcoder95 merged 2 commits intofastify:mainfrom
ChinoUkaegbu:chore/replace-var
Oct 22, 2024
Merged

refactor: change var instances to const or let#5759
metcoder95 merged 2 commits intofastify:mainfrom
ChinoUkaegbu:chore/replace-var

Conversation

@ChinoUkaegbu
Copy link
Contributor

@ChinoUkaegbu ChinoUkaegbu commented Oct 21, 2024

Closes #5756

Checklist

@ChinoUkaegbu
Copy link
Contributor Author

The configValidator file also has instances of var but the comment at the top indicates that it's not to be edited.

@Fdawgs Fdawgs changed the title chore: Change var instances to const or let refactor: change var instances to const or let Oct 21, 2024
@Fdawgs Fdawgs added the benchmark Label to run benchmark against PR and main branch label Oct 21, 2024
@github-actions
Copy link

Node: 20
PR: [1] 1551k requests in 30.04s, 291 MB read
MAIN: [1] 1568k requests in 30.05s, 295 MB read


Node: 22
PR: [1] 1545k requests in 30.04s, 290 MB read
MAIN: [1] 1524k requests in 30.04s, 286 MB read

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Oct 21, 2024
@github-actions
Copy link

Node: 20
PR: [1] 1459k requests in 30.06s, 274 MB read
MAIN: [1] 1439k requests in 30.04s, 270 MB read


Node: 22
PR: [1] 1320k requests in 30.04s, 248 MB read
MAIN: [1] 1310k requests in 30.04s, 246 MB read

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of var for initialising variables

6 participants