Skip to content

docs: Changed var for let and const#5745

Merged
Uzlopak merged 1 commit intofastify:mainfrom
BrunoMollo:main
Oct 17, 2024
Merged

docs: Changed var for let and const#5745
Uzlopak merged 1 commit intofastify:mainfrom
BrunoMollo:main

Conversation

@BrunoMollo
Copy link
Contributor

By reading the docs I found out that the var keyword is used in some snippets instead of let and const. As they are the recommended standard I took my time to change it.

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 343b69b into fastify:main Oct 17, 2024
@Fdawgs
Copy link
Member

Fdawgs commented Oct 17, 2024

We've got vars knocking about in some of our repos, for example in fastify itself. Worth swapping them out?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants