Skip to content

types: make plugin options required if they have any defined props#5637

Merged
mcollina merged 4 commits intofastify:mainfrom
paulius-valiunas:patch-1
Oct 18, 2024
Merged

types: make plugin options required if they have any defined props#5637
mcollina merged 4 commits intofastify:mainfrom
paulius-valiunas:patch-1

Conversation

@paulius-valiunas
Copy link
Contributor

No description provided.

Signed-off-by: Paulius Valiūnas <66480813+paulius-valiunas@users.noreply.github.com>
@github-actions github-actions bot added the typescript TypeScript related label Aug 22, 2024
@paulius-valiunas paulius-valiunas changed the title make plugin options required if they have any defined props types: make plugin options required if they have any defined props Aug 23, 2024
@paulius-valiunas paulius-valiunas marked this pull request as ready for review October 15, 2024 09:49
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulius-valiunas
Copy link
Contributor Author

@mcollina what's the next step here? Are you going to merge one of these PRs, or is someone else responsible for that?

@mcollina mcollina merged commit 29c121d into fastify:main Oct 18, 2024
@mcollina
Copy link
Member

None, I've landed

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

typescript TypeScript related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants