fix(backport 4.x): reorder handling of Response replies#5629
Merged
Conversation
Response repliesResponse replies
We must add Response.headers before proceeding, otherwise early returns (ie: 204) will miss them. We can also remove special handling of ReadableStream: since the Response usage is fully finished, we can continue with Response.body as the payload and the possible types 'null' or 'ReadableStream' will be handled by existing cases. Signed-off-by: Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
b2ae6e5 to
ed25fd7
Compare
Eomm
approved these changes
Aug 16, 2024
gurgunday
approved these changes
Aug 16, 2024
Author
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 3ececdd from #5612.