[Backport 4.x] feat: support different body schema per content type#5559
Merged
climba03003 merged 1 commit into4.xfrom Jul 17, 2024
Merged
[Backport 4.x] feat: support different body schema per content type#5559climba03003 merged 1 commit into4.xfrom
climba03003 merged 1 commit into4.xfrom
Conversation
* feat: support different body schema per content type * Add test for internal schema compiler * Consistent formatting of tests * Add test to avoid regression if types get stricter * Fix types test * Lint * Prefer single quoutes * Add docs with example schema * Remove unrelated formatting changes * Remove extra semicolon * Avoid using contractions Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Signed-off-by: Nico Flaig <nflaig@protonmail.com> * Reduce branches Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Signed-off-by: Nico Flaig <nflaig@protonmail.com> * Consistent variable naming * Add todo for adding request.contentType * Reduce nesting --------- Signed-off-by: Nico Flaig <nflaig@protonmail.com> Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> (cherry picked from commit f3ee7f7)
gurgunday
approved these changes
Jul 9, 2024
metcoder95
approved these changes
Jul 9, 2024
climba03003
approved these changes
Jul 17, 2024
Author
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport f3ee7f7 from #5545.