refactor(backport v4.x): change reply.redirect() signature (#5483)#5484
Merged
climba03003 merged 1 commit intofastify:4.xfrom May 27, 2024
Merged
refactor(backport v4.x): change reply.redirect() signature (#5483)#5484climba03003 merged 1 commit intofastify:4.xfrom
reply.redirect() signature (#5483)#5484climba03003 merged 1 commit intofastify:4.xfrom
Conversation
Member
Author
|
Alternative Runtimes node 18 never passes |
Member
Author
|
Only NodeSource's node 18 fails, all other versions including the vanilla node 18 and NodeSource 20 pass:
Interesting, I haven't verified but maybe it should skip this test (< v18.19) - in any case it's not about this PR |
Member
|
See #5486 for the reason |
* feat: change `reply.redirect()` signature * feat: change `reply.redirect()` signature * docs * docs * update message * fix deprecation * update message
fd5cb9a to
b04805d
Compare
reply.redirect() signature (#5483)reply.redirect() signature (#5483)
reply.redirect() signature (#5483)reply.redirect() signature (#5483)
climba03003
approved these changes
May 27, 2024
Member
|
You can use the |
Member
Author
|
When can we release this? To give users as much time as possible to see the deprecation Cc @mcollina |
renovate bot
referenced
this pull request
in tomacheese/telcheck
Jun 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.27.0` -> `4.28.0`](https://renovatebot.com/diffs/npm/fastify/4.27.0/4.28.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.28.0`](https://togithub.com/fastify/fastify/releases/tag/v4.28.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.27.0...v4.28.0) #### What's Changed - test: fix closing - pipelining by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5486](https://togithub.com/fastify/fastify/pull/5486) - refactor(backport v4.x): change `reply.redirect()` signature ([#​5483](https://togithub.com/fastify/fastify/issues/5483)) by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify/pull/5484](https://togithub.com/fastify/fastify/pull/5484) - refactor(backport v4.x): hasRoute method comparison with case insensitive by [@​SMNBLMRR](https://togithub.com/SMNBLMRR) in [https://github.com/fastify/fastify/pull/5513](https://togithub.com/fastify/fastify/pull/5513) - fix: (backport) Type inferrence with auxilliary hook handlers by [@​aadito123](https://togithub.com/aadito123) in [https://github.com/fastify/fastify/pull/5518](https://togithub.com/fastify/fastify/pull/5518) **Full Changelog**: fastify/fastify@v4.27.0...v4.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jul 13, 2024
renovate bot
referenced
this pull request
in redwoodjs/graphql
Jul 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.27.0` -> `4.28.1`](https://renovatebot.com/diffs/npm/fastify/4.27.0/4.28.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.28.1`](https://togithub.com/fastify/fastify/releases/tag/v4.28.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.28.0...v4.28.1) #### What's Changed - \[Backport 4.x] fix: server.listen listener is not cleanup properly by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/fastify/fastify/pull/5523](https://togithub.com/fastify/fastify/pull/5523) - \[Backport 4.x] test: fix test finished earlier than expected by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/fastify/fastify/pull/5541](https://togithub.com/fastify/fastify/pull/5541) - fix(v4): update .npmignore by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5538](https://togithub.com/fastify/fastify/pull/5538) **Full Changelog**: fastify/fastify@v4.28.0...v4.28.1 ### [`v4.28.0`](https://togithub.com/fastify/fastify/releases/tag/v4.28.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.27.0...v4.28.0) #### What's Changed - test: fix closing - pipelining by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5486](https://togithub.com/fastify/fastify/pull/5486) - refactor(backport v4.x): change `reply.redirect()` signature ([#​5483](https://togithub.com/fastify/fastify/issues/5483)) by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify/pull/5484](https://togithub.com/fastify/fastify/pull/5484) - refactor(backport v4.x): hasRoute method comparison with case insensitive by [@​SMNBLMRR](https://togithub.com/SMNBLMRR) in [https://github.com/fastify/fastify/pull/5513](https://togithub.com/fastify/fastify/pull/5513) - fix: (backport) Type inferrence with auxilliary hook handlers by [@​aadito123](https://togithub.com/aadito123) in [https://github.com/fastify/fastify/pull/5518](https://togithub.com/fastify/fastify/pull/5518) **Full Changelog**: fastify/fastify@v4.27.0...v4.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Aug 21, 2024
This was referenced Aug 28, 2024
This was referenced Sep 3, 2024
This was referenced Sep 8, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: change
reply.redirect()signaturefeat: change
reply.redirect()signaturedocs
docs
update message
fix deprecation
update message
Checklist
npm run testandnpm run benchmarkand the Code of conduct