fix: contentType match should not include invalid strings that start with the matched type#5371
Closed
gurgunday wants to merge 16 commits intofastify:nextfrom
Closed
fix: contentType match should not include invalid strings that start with the matched type#5371gurgunday wants to merge 16 commits intofastify:nextfrom
gurgunday wants to merge 16 commits intofastify:nextfrom
Conversation
This reverts commit c63b5fc.
2 tasks
Member
Author
|
CI unrelated |
4 tasks
metcoder95
approved these changes
Mar 25, 2024
Member
|
PRs are quite hard to review, maybe you can target them to its dependency branch so the diffs are lean? |
Member
Author
|
Branch is unfortunately on my account, maybe we can create a temp branch here, but I think if we go one by one I can rebase each time so it becomes clearer |
Member
Author
|
Merged at #5372 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant change: 448ef7b...657070d
Depends on: #5345
Currently, we match
text/htmlINVALIDwithtext/html, we shouldn't