docs(ecosystem): update x-ray community plugin link#5350
Merged
jsumners merged 3 commits intofastify:mainfrom Mar 10, 2024
Merged
docs(ecosystem): update x-ray community plugin link#5350jsumners merged 3 commits intofastify:mainfrom
jsumners merged 3 commits intofastify:mainfrom
Conversation
2 tasks
2 tasks
climba03003
requested changes
Mar 8, 2024
docs/Guides/Ecosystem.md
Outdated
| - [`fastify-xml-body-parser`](https://github.com/NaturalIntelligence/fastify-xml-body-parser) | ||
| Parse XML payload / request body into JS / JSON object. | ||
| - [`fastify-xray`](https://github.com/jeromemacias/fastify-xray) Fastify plugin | ||
| - [`fastify-xray`](https://github.com/aws/aws-xray-sdk-node/tree/master/sdk_contrib/fastify) Fastify plugin |
Member
There was a problem hiding this comment.
Your document is linked to https://www.npmjs.com/package/aws-xray-sdk-fastify
Please use the proper package name.
Since the package is belong to jeromemacias and the repository is archived.
I still want to ask if you wanted to be removed in the list and replaced by the aws version.
If not replied in few days, I assume yes.
Contributor
Author
There was a problem hiding this comment.
Package name updated.
Member
There was a problem hiding this comment.
Please arrange the plugin name to follow the alphabetical order.
Thanks.
climba03003
approved these changes
Mar 10, 2024
Open
1 task
This was referenced May 30, 2024
This was referenced Jun 1, 2024
This was referenced Jun 5, 2024
This was referenced Aug 21, 2024
This was referenced Aug 28, 2024
This was referenced Sep 3, 2024
This was referenced Sep 8, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Checklist
npm run testandnpm run benchmarkand the Code of conduct