feat: add use semicolon delimter config, default = true#5239
Merged
mcollina merged 5 commits intofastify:mainfrom Dec 27, 2023
Merged
feat: add use semicolon delimter config, default = true#5239mcollina merged 5 commits intofastify:mainfrom
mcollina merged 5 commits intofastify:mainfrom
Conversation
Uzlopak
reviewed
Dec 26, 2023
jsumners
previously requested changes
Dec 26, 2023
Member
jsumners
left a comment
There was a problem hiding this comment.
Please incorporate the information presented in #5050 (comment). It's really difficult to understand why this option exists without understanding how it came to be.
Member
|
can you check code coverage? |
metcoder95
reviewed
Dec 27, 2023
Member
metcoder95
left a comment
There was a problem hiding this comment.
Shall we add a baseline test for it?
My main concern has been addressed. I'm not convinced we should add the option, though. I think it might be better to issue a deprecation notice and then remove the possibility of the option in v5.
Uzlopak
reviewed
Dec 27, 2023
gurgunday
approved these changes
Dec 27, 2023
renovate bot
referenced
this pull request
in tomacheese/telcheck
Feb 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.25.2` -> `4.26.0`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0) #### What's Changed - docs(ecosystem): add missing plugins to core list by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5234](https://togithub.com/fastify/fastify/pull/5234) - ci: CITGM github workflow by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5233](https://togithub.com/fastify/fastify/pull/5233) - chore: bump find-may-way to v8.0.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5236](https://togithub.com/fastify/fastify/pull/5236) - fix: setValidatorCompiler with addSchema by [@​derammo](https://togithub.com/derammo) in [https://github.com/fastify/fastify/pull/5188](https://togithub.com/fastify/fastify/pull/5188) - feat(routes): expose findRoute and param validator by [@​sf3ris](https://togithub.com/sf3ris) in [https://github.com/fastify/fastify/pull/5230](https://togithub.com/fastify/fastify/pull/5230) - feat: add use semicolon delimter config, default = true by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5239](https://togithub.com/fastify/fastify/pull/5239) - chore: add autocannon and concurrently as dev dependencies by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5240](https://togithub.com/fastify/fastify/pull/5240) - fix: return the correct serializer function when no content-type is defined by [@​DouglasdeMoura](https://togithub.com/DouglasdeMoura) in [https://github.com/fastify/fastify/pull/5229](https://togithub.com/fastify/fastify/pull/5229) - Sync next by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5238](https://togithub.com/fastify/fastify/pull/5238) - docs: add open-collective by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5216](https://togithub.com/fastify/fastify/pull/5216) - chore: Bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5249](https://togithub.com/fastify/fastify/pull/5249) - chore: Bump actions/labeler from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5248](https://togithub.com/fastify/fastify/pull/5248) - docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to ecosystem.md by [@​Bugs5382](https://togithub.com/Bugs5382) in [https://github.com/fastify/fastify/pull/5245](https://togithub.com/fastify/fastify/pull/5245) - chore: update actions/labeler@5 by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5254](https://togithub.com/fastify/fastify/pull/5254) - fix: restrict findRoute exposed property by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5253](https://togithub.com/fastify/fastify/pull/5253) - fix(test): flaky on-listen hook test by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5256](https://togithub.com/fastify/fastify/pull/5256) - fix: remove unused promise warning in setNotFoundHandler with preHandler by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5258](https://togithub.com/fastify/fastify/pull/5258) - fix: Always call resource.emitDestroy() by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5228](https://togithub.com/fastify/fastify/pull/5228) - docs: Add missing punctuation in Ecosystem by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5261](https://togithub.com/fastify/fastify/pull/5261) - docs: remove word repetition on Decorators docs by [@​rlawisch](https://togithub.com/rlawisch) in [https://github.com/fastify/fastify/pull/5260](https://togithub.com/fastify/fastify/pull/5260) - chore(types): Remove unused type imports by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5264](https://togithub.com/fastify/fastify/pull/5264) - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5266](https://togithub.com/fastify/fastify/pull/5266) - chore(docs): Add clarification about `fastify.setErrorHandler()` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5265](https://togithub.com/fastify/fastify/pull/5265) - refactor: deprecate `Reply#getResponseTime()` in favour of `Reply#elapsedTime` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5263](https://togithub.com/fastify/fastify/pull/5263) - chore: remove `www.` from `fastify.dev` urls by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5270](https://togithub.com/fastify/fastify/pull/5270) - feat: expose method for setGenReqId on FastifyInstance by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5259](https://togithub.com/fastify/fastify/pull/5259) - fix: ensure `onListen` hooks are called when they should be by [@​bienzaaron](https://togithub.com/bienzaaron) in [https://github.com/fastify/fastify/pull/5273](https://togithub.com/fastify/fastify/pull/5273) - docs: re-word clarification about `setErrorHandler()` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5269](https://togithub.com/fastify/fastify/pull/5269) - docs(ecosystem): remove unsupported package by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5278](https://togithub.com/fastify/fastify/pull/5278) - docs: Fix Pino docs link by [@​BoscoDomingo](https://togithub.com/BoscoDomingo) in [https://github.com/fastify/fastify/pull/5284](https://togithub.com/fastify/fastify/pull/5284) - chore: add github sponsor by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5293](https://togithub.com/fastify/fastify/pull/5293) - docs(ecosystem): adds fastify-sqlite-typed to the community plugins list by [@​yoav0gal](https://togithub.com/yoav0gal) in [https://github.com/fastify/fastify/pull/5288](https://togithub.com/fastify/fastify/pull/5288) - docs: add ESM usage example in Getting Started by [@​atilagulers](https://togithub.com/atilagulers) in [https://github.com/fastify/fastify/pull/5294](https://togithub.com/fastify/fastify/pull/5294) - docs: repoint readers to shared `.github` files by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5268](https://togithub.com/fastify/fastify/pull/5268) - feat: Web Stream API by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5286](https://togithub.com/fastify/fastify/pull/5286) - chore: sync generated code by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5295](https://togithub.com/fastify/fastify/pull/5295) #### New Contributors - [@​derammo](https://togithub.com/derammo) made their first contribution in [https://github.com/fastify/fastify/pull/5188](https://togithub.com/fastify/fastify/pull/5188) - [@​DouglasdeMoura](https://togithub.com/DouglasdeMoura) made their first contribution in [https://github.com/fastify/fastify/pull/5229](https://togithub.com/fastify/fastify/pull/5229) - [@​rlawisch](https://togithub.com/rlawisch) made their first contribution in [https://github.com/fastify/fastify/pull/5260](https://togithub.com/fastify/fastify/pull/5260) - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [https://github.com/fastify/fastify/pull/5264](https://togithub.com/fastify/fastify/pull/5264) - [@​BoscoDomingo](https://togithub.com/BoscoDomingo) made their first contribution in [https://github.com/fastify/fastify/pull/5284](https://togithub.com/fastify/fastify/pull/5284) - [@​yoav0gal](https://togithub.com/yoav0gal) made their first contribution in [https://github.com/fastify/fastify/pull/5288](https://togithub.com/fastify/fastify/pull/5288) - [@​atilagulers](https://togithub.com/atilagulers) made their first contribution in [https://github.com/fastify/fastify/pull/5294](https://togithub.com/fastify/fastify/pull/5294) **Full Changelog**: fastify/fastify@v4.25.2...v4.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in redwoodjs/graphql
Mar 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.25.2` -> `4.26.2`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.26.2`](https://togithub.com/fastify/fastify/releases/tag/v4.26.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.1...v4.26.2) #### What's Changed - fix: typo in module exports by [@​lirantal](https://togithub.com/lirantal) in [https://github.com/fastify/fastify/pull/5316](https://togithub.com/fastify/fastify/pull/5316) - docs(ts): Fix links by [@​rozzilla](https://togithub.com/rozzilla) in [https://github.com/fastify/fastify/pull/5308](https://togithub.com/fastify/fastify/pull/5308) - fix: cb is not a function at fallbackErrorHandler by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5317](https://togithub.com/fastify/fastify/pull/5317) - feat: add a Firebase Functions step by step guide by [@​lirantal](https://togithub.com/lirantal) in [https://github.com/fastify/fastify/pull/5318](https://togithub.com/fastify/fastify/pull/5318) - types: fix test failure by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify/pull/5330](https://togithub.com/fastify/fastify/pull/5330) - perf: use FifoMap to check contentType by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify/pull/5331](https://togithub.com/fastify/fastify/pull/5331) - docs(ecosystem): adds fastify-override to plugins list by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5336](https://togithub.com/fastify/fastify/pull/5336) - types: Export preClose hook types by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5335](https://togithub.com/fastify/fastify/pull/5335) - fix: database migration doc missing db connection code by [@​nuhman](https://togithub.com/nuhman) in [https://github.com/fastify/fastify/pull/5339](https://togithub.com/fastify/fastify/pull/5339) - chore: Bump pnpm/action-setup from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5341](https://togithub.com/fastify/fastify/pull/5341) - chore: Bump xt0rted/markdownlint-problem-matcher from 2.0.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5342](https://togithub.com/fastify/fastify/pull/5342) #### New Contributors - [@​nuhman](https://togithub.com/nuhman) made their first contribution in [https://github.com/fastify/fastify/pull/5339](https://togithub.com/fastify/fastify/pull/5339) **Full Changelog**: fastify/fastify@v4.26.1...v4.26.2 ### [`v4.26.1`](https://togithub.com/fastify/fastify/releases/tag/v4.26.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.0...v4.26.1) #### What's Changed - docs(ecosystem): adds fastify-hana to the community plugins list by [@​yoav0gal](https://togithub.com/yoav0gal) in [https://github.com/fastify/fastify/pull/5289](https://togithub.com/fastify/fastify/pull/5289) - docs: fix misattributed property parent in deprecation warning: request.elapsedTime by [@​mscottnelson](https://togithub.com/mscottnelson) in [https://github.com/fastify/fastify/pull/5299](https://togithub.com/fastify/fastify/pull/5299) - chore: Bump lycheeverse/lychee-action from 1.8.0 to 1.9.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5300](https://togithub.com/fastify/fastify/pull/5300) - chore: Bump actions/dependency-review-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5301](https://togithub.com/fastify/fastify/pull/5301) - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5303](https://togithub.com/fastify/fastify/pull/5303) - fix: amend error codes for latest avvio v8.3.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5309](https://togithub.com/fastify/fastify/pull/5309) - fix(types): Request route options url add undefined by [@​rozzilla](https://togithub.com/rozzilla) in [https://github.com/fastify/fastify/pull/5307](https://togithub.com/fastify/fastify/pull/5307) - chore: add docs for tracing warnings by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/fastify/fastify/pull/5310](https://togithub.com/fastify/fastify/pull/5310) #### New Contributors - [@​mscottnelson](https://togithub.com/mscottnelson) made their first contribution in [https://github.com/fastify/fastify/pull/5299](https://togithub.com/fastify/fastify/pull/5299) **Full Changelog**: fastify/fastify@v4.26.0...v4.26.1 ### [`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0) #### What's Changed - docs(ecosystem): add missing plugins to core list by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5234](https://togithub.com/fastify/fastify/pull/5234) - ci: CITGM github workflow by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5233](https://togithub.com/fastify/fastify/pull/5233) - chore: bump find-may-way to v8.0.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5236](https://togithub.com/fastify/fastify/pull/5236) - fix: setValidatorCompiler with addSchema by [@​derammo](https://togithub.com/derammo) in [https://github.com/fastify/fastify/pull/5188](https://togithub.com/fastify/fastify/pull/5188) - feat(routes): expose findRoute and param validator by [@​sf3ris](https://togithub.com/sf3ris) in [https://github.com/fastify/fastify/pull/5230](https://togithub.com/fastify/fastify/pull/5230) - feat: add use semicolon delimter config, default = true by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5239](https://togithub.com/fastify/fastify/pull/5239) - chore: add autocannon and concurrently as dev dependencies by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5240](https://togithub.com/fastify/fastify/pull/5240) - fix: return the correct serializer function when no content-type is defined by [@​DouglasdeMoura](https://togithub.com/DouglasdeMoura) in [https://github.com/fastify/fastify/pull/5229](https://togithub.com/fastify/fastify/pull/5229) - Sync next by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5238](https://togithub.com/fastify/fastify/pull/5238) - docs: add open-collective by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5216](https://togithub.com/fastify/fastify/pull/5216) - chore: Bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5249](https://togithub.com/fastify/fastify/pull/5249) - chore: Bump actions/labeler from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5248](https://togithub.com/fastify/fastify/pull/5248) - docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to ecosystem.md by [@​Bugs5382](https://togithub.com/Bugs5382) in [https://github.com/fastify/fastify/pull/5245](https://togithub.com/fastify/fastify/pull/5245) - chore: update actions/labeler@5 by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5254](https://togithub.com/fastify/fastify/pull/5254) - fix: restrict findRoute exposed property by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5253](https://togithub.com/fastify/fastify/pull/5253) - fix(test): flaky on-listen hook test by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5256](https://togithub.com/fastify/fastify/pull/5256) - fix: remove unused promise warning in setNotFoundHandler with preHandler by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5258](https://togithub.com/fastify/fastify/pull/5258) - fix: Always call resource.emitDestroy() by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5228](https://togithub.com/fastify/fastify/pull/5228) - docs: Add missing punctuation in Ecosystem by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5261](https://togithub.com/fastify/fastify/pull/5261) - docs: remove word repetition on Decorators docs by [@​rlawisch](https://togithub.com/rlawisch) in [https://github.com/fastify/fastify/pull/5260](https://togithub.com/fastify/fastify/pull/5260) - chore(types): Remove unused type imports by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5264](https://togithub.com/fastify/fastify/pull/5264) - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5266](https://togithub.com/fastify/fastify/pull/5266) - chore(docs): Add clarification about `fastify.setErrorHandler()` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5265](https://togithub.com/fastify/fastify/pull/5265) - refactor: deprecate `Reply#getResponseTime()` in favour of `Reply#elapsedTime` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5263](https://togithub.com/fastify/fastify/pull/5263) - chore: remove `www.` from `fastify.dev` urls by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5270](https://togithub.com/fastify/fastify/pull/5270) - feat: expose method for setGenReqId on FastifyInstance by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5259](https://togithub.com/fastify/fastify/pull/5259) - fix: ensure `onListen` hooks are called when they should be by [@​bienzaaron](https://togithub.com/bienzaaron) in [https://github.com/fastify/fastify/pull/5273](https://togithub.com/fastify/fastify/pull/5273) - docs: re-word clarification about `setErrorHandler()` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5269](https://togithub.com/fastify/fastify/pull/5269) - docs(ecosystem): remove unsupported package by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5278](https://togithub.com/fastify/fastify/pull/5278) - docs: Fix Pino docs link by [@​BoscoDomingo](https://togithub.com/BoscoDomingo) in [https://github.com/fastify/fastify/pull/5284](https://togithub.com/fastify/fastify/pull/5284) - chore: add github sponsor by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5293](https://togithub.com/fastify/fastify/pull/5293) - docs(ecosystem): adds fastify-sqlite-typed to the community plugins list by [@​yoav0gal](https://togithub.com/yoav0gal) in [https://github.com/fastify/fastify/pull/5288](https://togithub.com/fastify/fastify/pull/5288) - docs: add ESM usage example in Getting Started by [@​atilagulers](https://togithub.com/atilagulers) in [https://github.com/fastify/fastify/pull/5294](https://togithub.com/fastify/fastify/pull/5294) - docs: repoint readers to shared `.github` files by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5268](https://togithub.com/fastify/fastify/pull/5268) - feat: Web Stream API by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5286](https://togithub.com/fastify/fastify/pull/5286) - chore: sync generated code by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5295](https://togithub.com/fastify/fastify/pull/5295) #### New Contributors - [@​derammo](https://togithub.com/derammo) made their first contribution in [https://github.com/fastify/fastify/pull/5188](https://togithub.com/fastify/fastify/pull/5188) - [@​DouglasdeMoura](https://togithub.com/DouglasdeMoura) made their first contribution in [https://github.com/fastify/fastify/pull/5229](https://togithub.com/fastify/fastify/pull/5229) - [@​rlawisch](https://togithub.com/rlawisch) made their first contribution in [https://github.com/fastify/fastify/pull/5260](https://togithub.com/fastify/fastify/pull/5260) - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [https://github.com/fastify/fastify/pull/5264](https://togithub.com/fastify/fastify/pull/5264) - [@​BoscoDomingo](https://togithub.com/BoscoDomingo) made their first contribution in [https://github.com/fastify/fastify/pull/5284](https://togithub.com/fastify/fastify/pull/5284) - [@​yoav0gal](https://togithub.com/yoav0gal) made their first contribution in [https://github.com/fastify/fastify/pull/5288](https://togithub.com/fastify/fastify/pull/5288) - [@​atilagulers](https://togithub.com/atilagulers) made their first contribution in [https://github.com/fastify/fastify/pull/5294](https://togithub.com/fastify/fastify/pull/5294) **Full Changelog**: fastify/fastify@v4.25.2...v4.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/graphql
Mar 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.25.2` -> `4.26.2`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>fastify/fastify (fastify)</summary> [`v4.26.2`](https://togithub.com/fastify/fastify/releases/tag/v4.26.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.1...v4.26.2) - fix: typo in module exports by [@​lirantal](https://togithub.com/lirantal) in [https://github.com/fastify/fastify/pull/5316](https://togithub.com/fastify/fastify/pull/5316) - docs(ts): Fix links by [@​rozzilla](https://togithub.com/rozzilla) in [https://github.com/fastify/fastify/pull/5308](https://togithub.com/fastify/fastify/pull/5308) - fix: cb is not a function at fallbackErrorHandler by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5317](https://togithub.com/fastify/fastify/pull/5317) - feat: add a Firebase Functions step by step guide by [@​lirantal](https://togithub.com/lirantal) in [https://github.com/fastify/fastify/pull/5318](https://togithub.com/fastify/fastify/pull/5318) - types: fix test failure by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify/pull/5330](https://togithub.com/fastify/fastify/pull/5330) - perf: use FifoMap to check contentType by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify/pull/5331](https://togithub.com/fastify/fastify/pull/5331) - docs(ecosystem): adds fastify-override to plugins list by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5336](https://togithub.com/fastify/fastify/pull/5336) - types: Export preClose hook types by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5335](https://togithub.com/fastify/fastify/pull/5335) - fix: database migration doc missing db connection code by [@​nuhman](https://togithub.com/nuhman) in [https://github.com/fastify/fastify/pull/5339](https://togithub.com/fastify/fastify/pull/5339) - chore: Bump pnpm/action-setup from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5341](https://togithub.com/fastify/fastify/pull/5341) - chore: Bump xt0rted/markdownlint-problem-matcher from 2.0.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5342](https://togithub.com/fastify/fastify/pull/5342) - [@​nuhman](https://togithub.com/nuhman) made their first contribution in [https://github.com/fastify/fastify/pull/5339](https://togithub.com/fastify/fastify/pull/5339) **Full Changelog**: fastify/fastify@v4.26.1...v4.26.2 [`v4.26.1`](https://togithub.com/fastify/fastify/releases/tag/v4.26.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.0...v4.26.1) - docs(ecosystem): adds fastify-hana to the community plugins list by [@​yoav0gal](https://togithub.com/yoav0gal) in [https://github.com/fastify/fastify/pull/5289](https://togithub.com/fastify/fastify/pull/5289) - docs: fix misattributed property parent in deprecation warning: request.elapsedTime by [@​mscottnelson](https://togithub.com/mscottnelson) in [https://github.com/fastify/fastify/pull/5299](https://togithub.com/fastify/fastify/pull/5299) - chore: Bump lycheeverse/lychee-action from 1.8.0 to 1.9.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5300](https://togithub.com/fastify/fastify/pull/5300) - chore: Bump actions/dependency-review-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5301](https://togithub.com/fastify/fastify/pull/5301) - chore(.gitignore): add .tap/ dir by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5303](https://togithub.com/fastify/fastify/pull/5303) - fix: amend error codes for latest avvio v8.3.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5309](https://togithub.com/fastify/fastify/pull/5309) - fix(types): Request route options url add undefined by [@​rozzilla](https://togithub.com/rozzilla) in [https://github.com/fastify/fastify/pull/5307](https://togithub.com/fastify/fastify/pull/5307) - chore: add docs for tracing warnings by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/fastify/fastify/pull/5310](https://togithub.com/fastify/fastify/pull/5310) - [@​mscottnelson](https://togithub.com/mscottnelson) made their first contribution in [https://github.com/fastify/fastify/pull/5299](https://togithub.com/fastify/fastify/pull/5299) **Full Changelog**: fastify/fastify@v4.26.0...v4.26.1 [`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0) - docs(ecosystem): add missing plugins to core list by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5234](https://togithub.com/fastify/fastify/pull/5234) - ci: CITGM github workflow by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5233](https://togithub.com/fastify/fastify/pull/5233) - chore: bump find-may-way to v8.0.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5236](https://togithub.com/fastify/fastify/pull/5236) - fix: setValidatorCompiler with addSchema by [@​derammo](https://togithub.com/derammo) in [https://github.com/fastify/fastify/pull/5188](https://togithub.com/fastify/fastify/pull/5188) - feat(routes): expose findRoute and param validator by [@​sf3ris](https://togithub.com/sf3ris) in [https://github.com/fastify/fastify/pull/5230](https://togithub.com/fastify/fastify/pull/5230) - feat: add use semicolon delimter config, default = true by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5239](https://togithub.com/fastify/fastify/pull/5239) - chore: add autocannon and concurrently as dev dependencies by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5240](https://togithub.com/fastify/fastify/pull/5240) - fix: return the correct serializer function when no content-type is defined by [@​DouglasdeMoura](https://togithub.com/DouglasdeMoura) in [https://github.com/fastify/fastify/pull/5229](https://togithub.com/fastify/fastify/pull/5229) - Sync next by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5238](https://togithub.com/fastify/fastify/pull/5238) - docs: add open-collective by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5216](https://togithub.com/fastify/fastify/pull/5216) - chore: Bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5249](https://togithub.com/fastify/fastify/pull/5249) - chore: Bump actions/labeler from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5248](https://togithub.com/fastify/fastify/pull/5248) - docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to ecosystem.md by [@​Bugs5382](https://togithub.com/Bugs5382) in [https://github.com/fastify/fastify/pull/5245](https://togithub.com/fastify/fastify/pull/5245) - chore: update actions/labeler@5 by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5254](https://togithub.com/fastify/fastify/pull/5254) - fix: restrict findRoute exposed property by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5253](https://togithub.com/fastify/fastify/pull/5253) - fix(test): flaky on-listen hook test by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/5256](https://togithub.com/fastify/fastify/pull/5256) - fix: remove unused promise warning in setNotFoundHandler with preHandler by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5258](https://togithub.com/fastify/fastify/pull/5258) - fix: Always call resource.emitDestroy() by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/5228](https://togithub.com/fastify/fastify/pull/5228) - docs: Add missing punctuation in Ecosystem by [@​matthyk](https://togithub.com/matthyk) in [https://github.com/fastify/fastify/pull/5261](https://togithub.com/fastify/fastify/pull/5261) - docs: remove word repetition on Decorators docs by [@​rlawisch](https://togithub.com/rlawisch) in [https://github.com/fastify/fastify/pull/5260](https://togithub.com/fastify/fastify/pull/5260) - chore(types): Remove unused type imports by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5264](https://togithub.com/fastify/fastify/pull/5264) - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5266](https://togithub.com/fastify/fastify/pull/5266) - chore(docs): Add clarification about `fastify.setErrorHandler()` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5265](https://togithub.com/fastify/fastify/pull/5265) - refactor: deprecate `Reply#getResponseTime()` in favour of `Reply#elapsedTime` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5263](https://togithub.com/fastify/fastify/pull/5263) - chore: remove `www.` from `fastify.dev` urls by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5270](https://togithub.com/fastify/fastify/pull/5270) - feat: expose method for setGenReqId on FastifyInstance by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5259](https://togithub.com/fastify/fastify/pull/5259) - fix: ensure `onListen` hooks are called when they should be by [@​bienzaaron](https://togithub.com/bienzaaron) in [https://github.com/fastify/fastify/pull/5273](https://togithub.com/fastify/fastify/pull/5273) - docs: re-word clarification about `setErrorHandler()` by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/fastify/fastify/pull/5269](https://togithub.com/fastify/fastify/pull/5269) - docs(ecosystem): remove unsupported package by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5278](https://togithub.com/fastify/fastify/pull/5278) - docs: Fix Pino docs link by [@​BoscoDomingo](https://togithub.com/BoscoDomingo) in [https://github.com/fastify/fastify/pull/5284](https://togithub.com/fastify/fastify/pull/5284) - chore: add github sponsor by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5293](https://togithub.com/fastify/fastify/pull/5293) - docs(ecosystem): adds fastify-sqlite-typed to the community plugins list by [@​yoav0gal](https://togithub.com/yoav0gal) in [https://github.com/fastify/fastify/pull/5288](https://togithub.com/fastify/fastify/pull/5288) - docs: add ESM usage example in Getting Started by [@​atilagulers](https://togithub.com/atilagulers) in [https://github.com/fastify/fastify/pull/5294](https://togithub.com/fastify/fastify/pull/5294) - docs: repoint readers to shared `.github` files by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5268](https://togithub.com/fastify/fastify/pull/5268) - feat: Web Stream API by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/5286](https://togithub.com/fastify/fastify/pull/5286) - chore: sync generated code by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5295](https://togithub.com/fastify/fastify/pull/5295) - [@​derammo](https://togithub.com/derammo) made their first contribution in [https://github.com/fastify/fastify/pull/5188](https://togithub.com/fastify/fastify/pull/5188) - [@​DouglasdeMoura](https://togithub.com/DouglasdeMoura) made their first contribution in [https://github.com/fastify/fastify/pull/5229](https://togithub.com/fastify/fastify/pull/5229) - [@​rlawisch](https://togithub.com/rlawisch) made their first contribution in [https://github.com/fastify/fastify/pull/5260](https://togithub.com/fastify/fastify/pull/5260) - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [https://github.com/fastify/fastify/pull/5264](https://togithub.com/fastify/fastify/pull/5264) - [@​BoscoDomingo](https://togithub.com/BoscoDomingo) made their first contribution in [https://github.com/fastify/fastify/pull/5284](https://togithub.com/fastify/fastify/pull/5284) - [@​yoav0gal](https://togithub.com/yoav0gal) made their first contribution in [https://github.com/fastify/fastify/pull/5288](https://togithub.com/fastify/fastify/pull/5288) - [@​atilagulers](https://togithub.com/atilagulers) made their first contribution in [https://github.com/fastify/fastify/pull/5294](https://togithub.com/fastify/fastify/pull/5294) **Full Changelog**: fastify/fastify@v4.25.2...v4.26.0 </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 22, 2024
This was referenced May 29, 2024
This was referenced Jun 5, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 21, 2024
This was referenced Aug 21, 2024
This was referenced Sep 3, 2024
This was referenced Sep 24, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
fixes: #5237
This PR adds
useSemicolonDefaultwith a default option oftruenpm run testandnpm run benchmarkand the Code of conduct