Merged
Conversation
mcollina
reviewed
Dec 25, 2023
Contributor
Author
163d493 to
8e5335b
Compare
Contributor
Author
|
@galvez |
Member
|
It does, it's just not integrated yet — let me try and move that task up in my queue... |
Contributor
Author
|
I invested alot of time, but I could not find a proper solution for fastify-funky. So I propose a workaround. @galvez I just commented out fastify-vite till it can run tests via If we merge the the remaining 3 PRs mentioned above, the citgm workflow would be green for ubuntu and node 20. |
258101e to
785a594
Compare
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 21, 2024
2 tasks
This was referenced Aug 21, 2024
This was referenced Sep 3, 2024
This was referenced Sep 24, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a CITGM github workflow as a PoC. This one is to run the core plugins.
You could trigger the workflow by assigning the "citgm-core-plugins" label to a PR.
We could add community-plugins and maybe projects like platformatic in other github workflows.
We could also trigger it via workflow dispatch, if we want.
See following action run result:
https://github.com/Uzlopak/fastify/actions/runs/7323976506
This workflow could mean, that we should change our release process. Curerntly @mcollina is updating the version in package.json and directly committing it. With citgm workflows in place, it would make sense to create a PR for updating the version in the package.json, then trigger citgm workflows. If its green, we merge the PR etc..
Currently some of the cases with databases fail. We could check if we add a npm script to those to spawn a database docker container?!fixedSome cases fail already, lol. My CITGM successfully detected incompatibilities... e.g. @fastify/throttle seems to be broken because we added detection of mixed callback and async await usage.fixedCurrently only node lts and ubuntu-latest is used. We should obviously discuss about using more node versions and add windows and macos. But as long the ubuntu and node lts tests are not green, and we did not agree on using this github workflow I would add them gradually after agreeing on using this approach.
Looking forward for your feedback ;).
Checklist
npm run testandnpm run benchmarkand the Code of conduct