docs(ecosystem): add http-wizard by flodlc · Pull Request #5132 · fastify/fastify

flodlc · 2023-10-31T16:44:26Z

Add http-wizard in the community ecosystem.
More information here:
https://http-wizard.vercel.app

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Add a library in the community ecosystem

Uzlopak

-1,

not a fastify specific package.

jsumners · 2023-11-02T12:05:02Z

Thank you for the submission, but the document being modified is a list of Fastify specific modules. A generic HTTP client does not fit that description.

flodlc · 2023-11-02T19:40:06Z

Thanks for the reply!
Actually it's made first for Fastify but not only.
If you had a look on my work and have feedback I would appreciate a lot 🙏

jsumners · 2023-11-02T20:32:12Z

I'm sorry, I do not understand how this tool is specific to Fastify. Can you provide some clarification?

flodlc · 2023-11-03T09:26:24Z

Sure, here is the doc example.

The props argument in the handle callback aligns directly with the fastify.route options.
It includes the method, url, and schema. These properties are also used by the http-wizard.createRoute method.
Using the same API as fastify.route ensures high compatibility with Fastify (that's intentional 🤝).

Http-wizard main goal is to have a tRPC-like DX for Fastify and bridging the gap between the back and the front.

export const getUsers = (fastify: FastifyInstance) => {
  return createRoute("/users", {
    method: "GET",
    schema: {
      response: {
        200: z.array(User),
      },
    },
  }).handle((props) => {
    fastify.route({
      ...props,
      handler: (request) => {
        const users = await db.getUsers();
        return users;
      },
    });
  });
};

jsumners · 2023-11-03T12:54:55Z

🤷‍♂️ I'll leave it up to @fastify/core

metcoder95 · 2023-11-03T15:23:17Z

I've mixed feelings about it. It seems not really a plugin, but more a tool mount on top of fastify (which is pretty good), but I believe the plugin section is not the right place. Maybe create a new one?

flodlc · 2023-11-03T15:26:19Z

Thanks all for your replies, it's good to see there is an interest !
I understand your thought, a new section would be great 👍

Uzlopak · 2023-11-03T16:10:25Z

Erm.. i still dont see it. Not from the name and not from the readme of http-wizard i see any connection to fastify.

For me it is a generic http client.

Also the description of the plugin in this PR is kind of misleading.

flodlc · 2023-11-07T18:37:27Z

Got it! Thanks for you time though 👍

kibertoad · 2023-11-07T20:42:06Z

I don't mind it being added under separate section, if project documentation is revised to make the trpc-for-fastify aspect more explicit.

If it can be useful for someone in our ecosystem, why not?

@kibertoad

What @kibertoad said.

flodlc · 2023-11-08T09:58:36Z

Http-wizard is really Fastify first, so I can easily turn the doc to make it more obvious in the next days

flodlc · 2023-11-08T13:50:24Z

Done ! Hope it helps @kibertoad
Would you like me to create a new section ?

Eomm

Would you like me to create a new section ?

Nope. A new section for 1 item would be odd.

I would merge this tool after the plugin tagging stuff: #4938

That PR is stale, would you mind to push it over the finish line?

flodlc · 2023-11-16T12:03:16Z

Sure, I wait for the #4938 to be merged.
I can take some time I guess 🕐

Doc has been improved to show usage with Fastify even more.

flodlc · 2023-11-16T12:05:42Z

Fastify got mentionned on the official react-query doc thanks to http-wizard 👍

Uzlopak · 2023-12-08T12:46:09Z

@Eomm
Is it ok to merge?

Uzlopak

LGTM

mcollina

lgtm

github-actions · 2024-12-09T00:31:33Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Update Ecosystem.md

a8410c7

Add a library in the community ecosystem

github-actions bot added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Oct 31, 2023

flodlc changed the title ~~Update Ecosystem.md~~ docs(ecosystem): add http-wizard Oct 31, 2023

flodlc added 2 commits October 31, 2023 18:07

Update Ecosystem.md

76e360d

Update Ecosystem.md

a072527

Uzlopak previously requested changes Nov 2, 2023

View reviewed changes

jsumners closed this Nov 2, 2023

jsumners reopened this Nov 3, 2023

flodlc added 2 commits November 3, 2023 15:05

Update Ecosystem.md

2874e82

Merge branch 'main' into patch-1

0022359

flodlc requested a review from Uzlopak November 3, 2023 14:26

Merge branch 'main' into patch-1

c9af8f5

Eomm requested changes Nov 9, 2023

View reviewed changes

Merge branch 'main' into patch-1

a08da0a

Uzlopak requested a review from Eomm December 8, 2023 12:45

Uzlopak approved these changes Dec 8, 2023

View reviewed changes

mcollina approved these changes Dec 8, 2023

View reviewed changes

kibertoad approved these changes Dec 8, 2023

View reviewed changes

Eomm approved these changes Dec 9, 2023

View reviewed changes

Eomm merged commit 85b0018 into fastify:main Dec 9, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024

Uh oh!

Conversation

flodlc commented Oct 31, 2023

Checklist

Uh oh!

Uzlopak left a comment

Choose a reason for hiding this comment

Uh oh!

jsumners commented Nov 2, 2023

Uh oh!

flodlc commented Nov 2, 2023

Uh oh!

jsumners commented Nov 2, 2023

Uh oh!

flodlc commented Nov 3, 2023

Uh oh!

jsumners commented Nov 3, 2023

Uh oh!

metcoder95 commented Nov 3, 2023

Uh oh!

flodlc commented Nov 3, 2023

Uh oh!

Uzlopak commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flodlc commented Nov 7, 2023

Uh oh!

kibertoad commented Nov 7, 2023

Uh oh!

flodlc commented Nov 8, 2023

Uh oh!

flodlc commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eomm left a comment

Choose a reason for hiding this comment

Uh oh!

flodlc commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flodlc commented Nov 16, 2023

Uh oh!

Uzlopak commented Dec 8, 2023

Uh oh!

Uzlopak left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uzlopak commented Nov 3, 2023 •

edited

Loading

flodlc commented Nov 8, 2023 •

edited

Loading

flodlc commented Nov 16, 2023 •

edited

Loading