feat: replace diagnostics_channel w/ dc-polyfill#5105
Closed
tlhunter wants to merge 1 commit intofastify:nextfrom
Closed
feat: replace diagnostics_channel w/ dc-polyfill#5105tlhunter wants to merge 1 commit intofastify:nextfrom
tlhunter wants to merge 1 commit intofastify:nextfrom
Conversation
Contributor
Author
|
Actually this really isn't all that useful on its own. I'll close it for now and will work on a larger change to introduce |
8 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the internal
diagnostics_channelmodule with thedc-polyfillpackage, which aims be backport and polyfill newer diagnostics channel features and bugfixes and make them available to older versions of Node.js. Specifically it supports versions as old as Node.js v12.17.I've removed the try/catch, but if Fastify runs on versions of Node.js older than 12.17 then I can add the try/catch back.
Checklist
npm run testandnpm run benchmarknextand in my branchnextbranch (117241.6)and the Code of conduct