Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Closed
2 tasks
jsumners
reviewed
Jul 21, 2023
bug.js
Outdated
Member
There was a problem hiding this comment.
Should this file be located in the test filesystem, e.g test/fixtures/? Maybe name it issue-4911.js?
metcoder95
reviewed
Jul 21, 2023
Uzlopak
requested changes
Jul 21, 2023
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
The title is not right i think.
"fix: ERR_REP_ALREADY_SENT explicitate that a handler is missing "return reply""
Is this about those async handlers? Than it should be
"fix: ERR_REP_ALREADY_SENT explicitate that an async handler is missing "return reply""
Fdawgs
requested changes
Jul 21, 2023
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
jsumners
approved these changes
Jul 24, 2023
Fdawgs
approved these changes
Jul 24, 2023
Eomm
approved these changes
Jul 24, 2023
renovate bot
referenced
this pull request
in tomacheese/telcheck
Jul 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.20.0` -> `4.21.0`](https://renovatebot.com/diffs/npm/fastify/4.20.0/4.21.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.21.0`](https://togithub.com/fastify/fastify/releases/tag/v4.21.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.20.0...v4.21.0) #### What's Changed - chore: remove license-checker package by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4914](https://togithub.com/fastify/fastify/pull/4914) - chore: remove pump devDependency by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4913](https://togithub.com/fastify/fastify/pull/4913) - ci: create artifacts in coverage workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4909](https://togithub.com/fastify/fastify/pull/4909) - docs(server): grammar and structure fixes by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/4904](https://togithub.com/fastify/fastify/pull/4904) - docs: Fix typo in TypeScript docs ("[@​types/node](https://togithub.com/types/node)", not "[@​node/types](https://togithub.com/node/types)") by [@​jasongwartz](https://togithub.com/jasongwartz) in [https://github.com/fastify/fastify/pull/4922](https://togithub.com/fastify/fastify/pull/4922) - \[readme] add CII Best Practices Badge by [@​ljharb](https://togithub.com/ljharb) in [https://github.com/fastify/fastify/pull/4926](https://togithub.com/fastify/fastify/pull/4926) - fix: lowercase type-providers headers types by [@​toomuchdesign](https://togithub.com/toomuchdesign) in [https://github.com/fastify/fastify/pull/4928](https://togithub.com/fastify/fastify/pull/4928) - ERR_REP_ALREADY_SENT hint that a route may be missing "return reply" by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4921](https://togithub.com/fastify/fastify/pull/4921) - fix: ReplyTypeConstrainer array type inference by [@​pedroescumalha](https://togithub.com/pedroescumalha) in [https://github.com/fastify/fastify/pull/4885](https://togithub.com/fastify/fastify/pull/4885) #### New Contributors - [@​jasongwartz](https://togithub.com/jasongwartz) made their first contribution in [https://github.com/fastify/fastify/pull/4922](https://togithub.com/fastify/fastify/pull/4922) - [@​ljharb](https://togithub.com/ljharb) made their first contribution in [https://github.com/fastify/fastify/pull/4926](https://togithub.com/fastify/fastify/pull/4926) - [@​toomuchdesign](https://togithub.com/toomuchdesign) made their first contribution in [https://github.com/fastify/fastify/pull/4928](https://togithub.com/fastify/fastify/pull/4928) - [@​pedroescumalha](https://togithub.com/pedroescumalha) made their first contribution in [https://github.com/fastify/fastify/pull/4885](https://togithub.com/fastify/fastify/pull/4885) **Full Changelog**: fastify/fastify@v4.20.0...v4.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in redwoodjs/graphql
Aug 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.20.0` -> `4.21.0`](https://renovatebot.com/diffs/npm/fastify/4.20.0/4.21.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.21.0`](https://togithub.com/fastify/fastify/releases/tag/v4.21.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.20.0...v4.21.0) #### What's Changed - chore: remove license-checker package by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4914](https://togithub.com/fastify/fastify/pull/4914) - chore: remove pump devDependency by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4913](https://togithub.com/fastify/fastify/pull/4913) - ci: create artifacts in coverage workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4909](https://togithub.com/fastify/fastify/pull/4909) - docs(server): grammar and structure fixes by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/4904](https://togithub.com/fastify/fastify/pull/4904) - docs: Fix typo in TypeScript docs ("[@​types/node](https://togithub.com/types/node)", not "[@​node/types](https://togithub.com/node/types)") by [@​jasongwartz](https://togithub.com/jasongwartz) in [https://github.com/fastify/fastify/pull/4922](https://togithub.com/fastify/fastify/pull/4922) - \[readme] add CII Best Practices Badge by [@​ljharb](https://togithub.com/ljharb) in [https://github.com/fastify/fastify/pull/4926](https://togithub.com/fastify/fastify/pull/4926) - fix: lowercase type-providers headers types by [@​toomuchdesign](https://togithub.com/toomuchdesign) in [https://github.com/fastify/fastify/pull/4928](https://togithub.com/fastify/fastify/pull/4928) - ERR_REP_ALREADY_SENT hint that a route may be missing "return reply" by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4921](https://togithub.com/fastify/fastify/pull/4921) - fix: ReplyTypeConstrainer array type inference by [@​pedroescumalha](https://togithub.com/pedroescumalha) in [https://github.com/fastify/fastify/pull/4885](https://togithub.com/fastify/fastify/pull/4885) #### New Contributors - [@​jasongwartz](https://togithub.com/jasongwartz) made their first contribution in [https://github.com/fastify/fastify/pull/4922](https://togithub.com/fastify/fastify/pull/4922) - [@​ljharb](https://togithub.com/ljharb) made their first contribution in [https://github.com/fastify/fastify/pull/4926](https://togithub.com/fastify/fastify/pull/4926) - [@​toomuchdesign](https://togithub.com/toomuchdesign) made their first contribution in [https://github.com/fastify/fastify/pull/4928](https://togithub.com/fastify/fastify/pull/4928) - [@​pedroescumalha](https://togithub.com/pedroescumalha) made their first contribution in [https://github.com/fastify/fastify/pull/4885](https://togithub.com/fastify/fastify/pull/4885) **Full Changelog**: fastify/fastify@v4.20.0...v4.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4911
Checklist
npm run testandnpm run benchmarkand the Code of conduct