Revert "docs(client-aborted): remove deprecated function (#4898)" by climba03003 · Pull Request #4901 · fastify/fastify

climba03003 · 2023-07-14T11:38:28Z

This reverts commit cc347d7.

The author on #4898 do not test if request.aborted is really identical to request.destoryed.
Instead, they are two completely different property and the meaning is different.

For request.destoryed, Node.js document is telling us to Check but not Use as replacement.

From the below example, a properly closed connection would also triggered when using request.destroyed.
So, it is not meaning request abort.

test('onRequestAbort should not be called when using destroyed', t => {
  const fastify = Fastify()

  t.plan(3)
  t.teardown(() => fastify.close())

  fastify.addHook('onRequestAbort', async function (req) {
    process.nextTick(() => t.fail())
  })

  fastify.route({
    method: 'GET',
    path: '/',
    async handler (request, reply) {
      return { hello: 'world' }
    }
  })

  fastify.listen({ port: 0 }, (err, address) => {
    t.error(err)

    sget({
      method: 'GET',
      url: address
    }, (err, response, body) => {
      t.error(err)
      t.equal(response.statusCode, 200)
    })
  })
})

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

This reverts commit cc347d7.

Fdawgs

Thanks @climba03003

github-actions · 2024-07-15T00:24:59Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Revert "docs(client-aborted): remove deprecated function (#4898)"

738b5d4

This reverts commit cc347d7.

github-actions bot added the documentation Improvements or additions to documentation label Jul 14, 2023

jsumners approved these changes Jul 14, 2023

View reviewed changes

metcoder95 approved these changes Jul 14, 2023

View reviewed changes

Fdawgs approved these changes Jul 15, 2023

View reviewed changes

Fdawgs merged commit 4e081d4 into main Jul 15, 2023

Fdawgs deleted the revert-4898 branch July 15, 2023 06:25

github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "docs(client-aborted): remove deprecated function (#4898)"#4901

Revert "docs(client-aborted): remove deprecated function (#4898)"#4901
Fdawgs merged 1 commit intomainfrom
revert-4898

climba03003 commented Jul 14, 2023 •

edited by Fdawgs

Loading

Uh oh!

Fdawgs left a comment

Uh oh!

github-actions bot commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

climba03003 commented Jul 14, 2023 • edited by Fdawgs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Fdawgs left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

climba03003 commented Jul 14, 2023 •

edited by Fdawgs

Loading