fix: rework FastifyErrors, ensure documentation completeness#4892
Merged
fix: rework FastifyErrors, ensure documentation completeness#4892
Conversation
climba03003
requested changes
Jul 10, 2023
metcoder95
approved these changes
Jul 10, 2023
Member
metcoder95
left a comment
There was a problem hiding this comment.
LGTM, I just share the same concern as @climba03003 for the status code change. And, your suggestion SGTM as well 👍
Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
Uzlopak
commented
Jul 10, 2023
Contributor
Author
|
FST_ERR_INVALID_URL is now again status code 400 |
climba03003
approved these changes
Jul 10, 2023
renovate bot
referenced
this pull request
in tomacheese/telcheck
Jul 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.19.2` -> `4.20.0`](https://renovatebot.com/diffs/npm/fastify/4.19.2/4.20.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.20.0`](https://togithub.com/fastify/fastify/releases/tag/v4.20.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.19.2...v4.20.0) #### What's Changed - build(deps-dev): Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.28.20 to 0.29.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4877](https://togithub.com/fastify/fastify/pull/4877) - Update Prototype-Poisoning.md by [@​ed-henrique](https://togithub.com/ed-henrique) in [https://github.com/fastify/fastify/pull/4879](https://togithub.com/fastify/fastify/pull/4879) - docs: adjust line for linter by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/fastify/fastify/pull/4882](https://togithub.com/fastify/fastify/pull/4882) - Fixed type inference on .code().send() by [@​aadito123](https://togithub.com/aadito123) in [https://github.com/fastify/fastify/pull/4880](https://togithub.com/fastify/fastify/pull/4880) - chore: refactor Error-typings and tests by [@​svrnwnsch](https://togithub.com/svrnwnsch) in [https://github.com/fastify/fastify/pull/4824](https://togithub.com/fastify/fastify/pull/4824) - test: add missing assertion for a test by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/fastify/fastify/pull/4701](https://togithub.com/fastify/fastify/pull/4701) - chore: tests for genReqIdFactory and minor changes by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4783](https://togithub.com/fastify/fastify/pull/4783) - Added type definition for allowUnsafeRegex by [@​xijdk](https://togithub.com/xijdk) in [https://github.com/fastify/fastify/pull/4792](https://togithub.com/fastify/fastify/pull/4792) - docs(security): update policy on ci/cd reports by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/fastify/fastify/pull/4890](https://togithub.com/fastify/fastify/pull/4890) - improve hooks.validate by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4804](https://togithub.com/fastify/fastify/pull/4804) - ci: enable caching; split jobs by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4889](https://togithub.com/fastify/fastify/pull/4889) - docs(plugins): note side-effect when using `await` in `fastify.register()` by [@​hateablestream](https://togithub.com/hateablestream) in [https://github.com/fastify/fastify/pull/4846](https://togithub.com/fastify/fastify/pull/4846) - \[hooks] Refine hook runners by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4805](https://togithub.com/fastify/fastify/pull/4805) - docs: fix wrong header size for FST_ERR_ASYNC_CONSTRAINT in Errors.md by [@​graphiteisaac](https://togithub.com/graphiteisaac) in [https://github.com/fastify/fastify/pull/4893](https://togithub.com/fastify/fastify/pull/4893) - fix: rework FastifyErrors, ensure documentation completeness by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4892](https://togithub.com/fastify/fastify/pull/4892) - feat: add childLoggerFactory config by [@​brettwillis](https://togithub.com/brettwillis) in [https://github.com/fastify/fastify/pull/4760](https://togithub.com/fastify/fastify/pull/4760) - Fix setNotFoundHandler handler type by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/fastify/fastify/pull/4897](https://togithub.com/fastify/fastify/pull/4897) - restore code coverage by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4841](https://togithub.com/fastify/fastify/pull/4841) - fix: handle abort signal before server is ready by [@​shayff](https://togithub.com/shayff) in [https://github.com/fastify/fastify/pull/4886](https://togithub.com/fastify/fastify/pull/4886) - docs(client-aborted): remove deprecated function by [@​JekRock](https://togithub.com/JekRock) in [https://github.com/fastify/fastify/pull/4898](https://togithub.com/fastify/fastify/pull/4898) - Revert "docs(client-aborted): remove deprecated function ([#​4898](https://togithub.com/fastify/fastify/issues/4898))" by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4901](https://togithub.com/fastify/fastify/pull/4901) - docs(logging): fix typo by [@​yamanidev](https://togithub.com/yamanidev) in [https://github.com/fastify/fastify/pull/4905](https://togithub.com/fastify/fastify/pull/4905) - Support IPv6 ::1 in listeningOrigin by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4902](https://togithub.com/fastify/fastify/pull/4902) - fix: extend isCustomValidatorCompiler from parent controller by [@​tinchoz49](https://togithub.com/tinchoz49) in [https://github.com/fastify/fastify/pull/4903](https://togithub.com/fastify/fastify/pull/4903) - fix: allow uppercase requestdHeader by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4906](https://togithub.com/fastify/fastify/pull/4906) #### New Contributors - [@​ed-henrique](https://togithub.com/ed-henrique) made their first contribution in [https://github.com/fastify/fastify/pull/4879](https://togithub.com/fastify/fastify/pull/4879) - [@​svrnwnsch](https://togithub.com/svrnwnsch) made their first contribution in [https://github.com/fastify/fastify/pull/4824](https://togithub.com/fastify/fastify/pull/4824) - [@​xijdk](https://togithub.com/xijdk) made their first contribution in [https://github.com/fastify/fastify/pull/4792](https://togithub.com/fastify/fastify/pull/4792) - [@​hateablestream](https://togithub.com/hateablestream) made their first contribution in [https://github.com/fastify/fastify/pull/4846](https://togithub.com/fastify/fastify/pull/4846) - [@​graphiteisaac](https://togithub.com/graphiteisaac) made their first contribution in [https://github.com/fastify/fastify/pull/4893](https://togithub.com/fastify/fastify/pull/4893) - [@​shayff](https://togithub.com/shayff) made their first contribution in [https://github.com/fastify/fastify/pull/4886](https://togithub.com/fastify/fastify/pull/4886) - [@​JekRock](https://togithub.com/JekRock) made their first contribution in [https://github.com/fastify/fastify/pull/4898](https://togithub.com/fastify/fastify/pull/4898) - [@​yamanidev](https://togithub.com/yamanidev) made their first contribution in [https://github.com/fastify/fastify/pull/4905](https://togithub.com/fastify/fastify/pull/4905) - [@​tinchoz49](https://togithub.com/tinchoz49) made their first contribution in [https://github.com/fastify/fastify/pull/4903](https://togithub.com/fastify/fastify/pull/4903) **Full Changelog**: fastify/fastify@v4.19.2...v4.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in redwoodjs/graphql
Jul 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.19.2` -> `4.20.0`](https://renovatebot.com/diffs/npm/fastify/4.19.2/4.20.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.20.0`](https://togithub.com/fastify/fastify/releases/tag/v4.20.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.19.2...v4.20.0) #### What's Changed - build(deps-dev): Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.28.20 to 0.29.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4877](https://togithub.com/fastify/fastify/pull/4877) - Update Prototype-Poisoning.md by [@​ed-henrique](https://togithub.com/ed-henrique) in [https://github.com/fastify/fastify/pull/4879](https://togithub.com/fastify/fastify/pull/4879) - docs: adjust line for linter by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/fastify/fastify/pull/4882](https://togithub.com/fastify/fastify/pull/4882) - Fixed type inference on .code().send() by [@​aadito123](https://togithub.com/aadito123) in [https://github.com/fastify/fastify/pull/4880](https://togithub.com/fastify/fastify/pull/4880) - chore: refactor Error-typings and tests by [@​svrnwnsch](https://togithub.com/svrnwnsch) in [https://github.com/fastify/fastify/pull/4824](https://togithub.com/fastify/fastify/pull/4824) - test: add missing assertion for a test by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/fastify/fastify/pull/4701](https://togithub.com/fastify/fastify/pull/4701) - chore: tests for genReqIdFactory and minor changes by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4783](https://togithub.com/fastify/fastify/pull/4783) - Added type definition for allowUnsafeRegex by [@​xijdk](https://togithub.com/xijdk) in [https://github.com/fastify/fastify/pull/4792](https://togithub.com/fastify/fastify/pull/4792) - docs(security): update policy on ci/cd reports by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/fastify/fastify/pull/4890](https://togithub.com/fastify/fastify/pull/4890) - improve hooks.validate by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4804](https://togithub.com/fastify/fastify/pull/4804) - ci: enable caching; split jobs by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4889](https://togithub.com/fastify/fastify/pull/4889) - docs(plugins): note side-effect when using `await` in `fastify.register()` by [@​hateablestream](https://togithub.com/hateablestream) in [https://github.com/fastify/fastify/pull/4846](https://togithub.com/fastify/fastify/pull/4846) - \[hooks] Refine hook runners by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4805](https://togithub.com/fastify/fastify/pull/4805) - docs: fix wrong header size for FST_ERR_ASYNC_CONSTRAINT in Errors.md by [@​graphiteisaac](https://togithub.com/graphiteisaac) in [https://github.com/fastify/fastify/pull/4893](https://togithub.com/fastify/fastify/pull/4893) - fix: rework FastifyErrors, ensure documentation completeness by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4892](https://togithub.com/fastify/fastify/pull/4892) - feat: add childLoggerFactory config by [@​brettwillis](https://togithub.com/brettwillis) in [https://github.com/fastify/fastify/pull/4760](https://togithub.com/fastify/fastify/pull/4760) - Fix setNotFoundHandler handler type by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/fastify/fastify/pull/4897](https://togithub.com/fastify/fastify/pull/4897) - restore code coverage by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4841](https://togithub.com/fastify/fastify/pull/4841) - fix: handle abort signal before server is ready by [@​shayff](https://togithub.com/shayff) in [https://github.com/fastify/fastify/pull/4886](https://togithub.com/fastify/fastify/pull/4886) - docs(client-aborted): remove deprecated function by [@​JekRock](https://togithub.com/JekRock) in [https://github.com/fastify/fastify/pull/4898](https://togithub.com/fastify/fastify/pull/4898) - Revert "docs(client-aborted): remove deprecated function ([#​4898](https://togithub.com/fastify/fastify/issues/4898))" by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4901](https://togithub.com/fastify/fastify/pull/4901) - docs(logging): fix typo by [@​yamanidev](https://togithub.com/yamanidev) in [https://github.com/fastify/fastify/pull/4905](https://togithub.com/fastify/fastify/pull/4905) - Support IPv6 ::1 in listeningOrigin by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4902](https://togithub.com/fastify/fastify/pull/4902) - fix: extend isCustomValidatorCompiler from parent controller by [@​tinchoz49](https://togithub.com/tinchoz49) in [https://github.com/fastify/fastify/pull/4903](https://togithub.com/fastify/fastify/pull/4903) - fix: allow uppercase requestdHeader by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4906](https://togithub.com/fastify/fastify/pull/4906) #### New Contributors - [@​ed-henrique](https://togithub.com/ed-henrique) made their first contribution in [https://github.com/fastify/fastify/pull/4879](https://togithub.com/fastify/fastify/pull/4879) - [@​svrnwnsch](https://togithub.com/svrnwnsch) made their first contribution in [https://github.com/fastify/fastify/pull/4824](https://togithub.com/fastify/fastify/pull/4824) - [@​xijdk](https://togithub.com/xijdk) made their first contribution in [https://github.com/fastify/fastify/pull/4792](https://togithub.com/fastify/fastify/pull/4792) - [@​hateablestream](https://togithub.com/hateablestream) made their first contribution in [https://github.com/fastify/fastify/pull/4846](https://togithub.com/fastify/fastify/pull/4846) - [@​graphiteisaac](https://togithub.com/graphiteisaac) made their first contribution in [https://github.com/fastify/fastify/pull/4893](https://togithub.com/fastify/fastify/pull/4893) - [@​shayff](https://togithub.com/shayff) made their first contribution in [https://github.com/fastify/fastify/pull/4886](https://togithub.com/fastify/fastify/pull/4886) - [@​JekRock](https://togithub.com/JekRock) made their first contribution in [https://github.com/fastify/fastify/pull/4898](https://togithub.com/fastify/fastify/pull/4898) - [@​yamanidev](https://togithub.com/yamanidev) made their first contribution in [https://github.com/fastify/fastify/pull/4905](https://togithub.com/fastify/fastify/pull/4905) - [@​tinchoz49](https://togithub.com/tinchoz49) made their first contribution in [https://github.com/fastify/fastify/pull/4903](https://togithub.com/fastify/fastify/pull/4903) **Full Changelog**: fastify/fastify@v4.19.2...v4.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/graphql
Jul 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.19.2` -> `4.20.0`](https://renovatebot.com/diffs/npm/fastify/4.19.2/4.20.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.20.0`](https://togithub.com/fastify/fastify/releases/tag/v4.20.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.19.2...v4.20.0) #### What's Changed - build(deps-dev): Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.28.20 to 0.29.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/4877](https://togithub.com/fastify/fastify/pull/4877) - Update Prototype-Poisoning.md by [@​ed-henrique](https://togithub.com/ed-henrique) in [https://github.com/fastify/fastify/pull/4879](https://togithub.com/fastify/fastify/pull/4879) - docs: adjust line for linter by [@​metcoder95](https://togithub.com/metcoder95) in [https://github.com/fastify/fastify/pull/4882](https://togithub.com/fastify/fastify/pull/4882) - Fixed type inference on .code().send() by [@​aadito123](https://togithub.com/aadito123) in [https://github.com/fastify/fastify/pull/4880](https://togithub.com/fastify/fastify/pull/4880) - chore: refactor Error-typings and tests by [@​svrnwnsch](https://togithub.com/svrnwnsch) in [https://github.com/fastify/fastify/pull/4824](https://togithub.com/fastify/fastify/pull/4824) - test: add missing assertion for a test by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/fastify/fastify/pull/4701](https://togithub.com/fastify/fastify/pull/4701) - chore: tests for genReqIdFactory and minor changes by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4783](https://togithub.com/fastify/fastify/pull/4783) - Added type definition for allowUnsafeRegex by [@​xijdk](https://togithub.com/xijdk) in [https://github.com/fastify/fastify/pull/4792](https://togithub.com/fastify/fastify/pull/4792) - docs(security): update policy on ci/cd reports by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/fastify/fastify/pull/4890](https://togithub.com/fastify/fastify/pull/4890) - improve hooks.validate by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4804](https://togithub.com/fastify/fastify/pull/4804) - ci: enable caching; split jobs by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4889](https://togithub.com/fastify/fastify/pull/4889) - docs(plugins): note side-effect when using `await` in `fastify.register()` by [@​hateablestream](https://togithub.com/hateablestream) in [https://github.com/fastify/fastify/pull/4846](https://togithub.com/fastify/fastify/pull/4846) - \[hooks] Refine hook runners by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4805](https://togithub.com/fastify/fastify/pull/4805) - docs: fix wrong header size for FST_ERR_ASYNC_CONSTRAINT in Errors.md by [@​graphiteisaac](https://togithub.com/graphiteisaac) in [https://github.com/fastify/fastify/pull/4893](https://togithub.com/fastify/fastify/pull/4893) - fix: rework FastifyErrors, ensure documentation completeness by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4892](https://togithub.com/fastify/fastify/pull/4892) - feat: add childLoggerFactory config by [@​brettwillis](https://togithub.com/brettwillis) in [https://github.com/fastify/fastify/pull/4760](https://togithub.com/fastify/fastify/pull/4760) - Fix setNotFoundHandler handler type by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/fastify/fastify/pull/4897](https://togithub.com/fastify/fastify/pull/4897) - restore code coverage by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4841](https://togithub.com/fastify/fastify/pull/4841) - fix: handle abort signal before server is ready by [@​shayff](https://togithub.com/shayff) in [https://github.com/fastify/fastify/pull/4886](https://togithub.com/fastify/fastify/pull/4886) - docs(client-aborted): remove deprecated function by [@​JekRock](https://togithub.com/JekRock) in [https://github.com/fastify/fastify/pull/4898](https://togithub.com/fastify/fastify/pull/4898) - Revert "docs(client-aborted): remove deprecated function ([#​4898](https://togithub.com/fastify/fastify/issues/4898))" by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify/pull/4901](https://togithub.com/fastify/fastify/pull/4901) - docs(logging): fix typo by [@​yamanidev](https://togithub.com/yamanidev) in [https://github.com/fastify/fastify/pull/4905](https://togithub.com/fastify/fastify/pull/4905) - Support IPv6 ::1 in listeningOrigin by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify/pull/4902](https://togithub.com/fastify/fastify/pull/4902) - fix: extend isCustomValidatorCompiler from parent controller by [@​tinchoz49](https://togithub.com/tinchoz49) in [https://github.com/fastify/fastify/pull/4903](https://togithub.com/fastify/fastify/pull/4903) - fix: allow uppercase requestdHeader by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/fastify/fastify/pull/4906](https://togithub.com/fastify/fastify/pull/4906) #### New Contributors - [@​ed-henrique](https://togithub.com/ed-henrique) made their first contribution in [https://github.com/fastify/fastify/pull/4879](https://togithub.com/fastify/fastify/pull/4879) - [@​svrnwnsch](https://togithub.com/svrnwnsch) made their first contribution in [https://github.com/fastify/fastify/pull/4824](https://togithub.com/fastify/fastify/pull/4824) - [@​xijdk](https://togithub.com/xijdk) made their first contribution in [https://github.com/fastify/fastify/pull/4792](https://togithub.com/fastify/fastify/pull/4792) - [@​hateablestream](https://togithub.com/hateablestream) made their first contribution in [https://github.com/fastify/fastify/pull/4846](https://togithub.com/fastify/fastify/pull/4846) - [@​graphiteisaac](https://togithub.com/graphiteisaac) made their first contribution in [https://github.com/fastify/fastify/pull/4893](https://togithub.com/fastify/fastify/pull/4893) - [@​shayff](https://togithub.com/shayff) made their first contribution in [https://github.com/fastify/fastify/pull/4886](https://togithub.com/fastify/fastify/pull/4886) - [@​JekRock](https://togithub.com/JekRock) made their first contribution in [https://github.com/fastify/fastify/pull/4898](https://togithub.com/fastify/fastify/pull/4898) - [@​yamanidev](https://togithub.com/yamanidev) made their first contribution in [https://github.com/fastify/fastify/pull/4905](https://togithub.com/fastify/fastify/pull/4905) - [@​tinchoz49](https://togithub.com/tinchoz49) made their first contribution in [https://github.com/fastify/fastify/pull/4903](https://togithub.com/fastify/fastify/pull/4903) **Full Changelog**: fastify/fastify@v4.19.2...v4.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
This was referenced Jun 29, 2024
Closed
This was referenced Jun 29, 2024
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw first some issues on the Errors documentation on fastify.dev, like so:
So I started fixing them manually. But then I realized, that I am a lazy guy. So I wrote unit tests, to ensure that the documentation is regarding Errors complete.
Then I realized, that some of those Errors should be TypeErrors, so I also fixed that.
Checklist
npm run testandnpm run benchmarkand the Code of conduct