Reorder Generic Types of FastifyReply#4415
Conversation
|
What does @fastify/typescript think of this change? |
climba03003
left a comment
There was a problem hiding this comment.
Re-order is good, but it is not safe to land in main.
|
I do agree on that because it might be a breaking change. If you may suggest a different destination branch I'm more than willing to change it. |
|
You can target to |
|
Thanks @climba03003 for the feedback. Target branch changed to |
|
I changed the title to express better what this PR is doing. |
|
Can you rebase again. It included other commit in your PR. |
f723204 to
425b22b
Compare
425b22b to
337bdb5
Compare
|
@climba03003 I've been finally able to rebase the pull request. Sorry but I don't feel comfortable with rebasing. |
I usually use GUI for rebasing, command would be too complicated if you don't familiar with |
|
@climba03003 I don't want to go off-topic, but I'd like to know more about the GUI you're using (is it tortoise, perhaps?). I normally use this command |
I use |
|
@climba03003 Thanks for the info, I'll take a look. |
|
@climba03003 |
|
Uff, I think this also means that all plugins, which decorate fastifyReply need changes. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue: #4414
I didn't feel the need to write new tests since we are just reordering reply types.
Checklist
npm run testandnpm run benchmarkand the Code of conduct