Merged
Conversation
Fdawgs
requested changes
Jun 10, 2022
mcollina
requested changes
Jun 10, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
This setup only runs in CI. I think we should be able to run locally too. I think remark might offer a better toolchain but I'm ok with anything I can run locally as well.
(In Node.js TSC we use https://github.com/nodejs/TSC/blob/main/package.json#L7)
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Fdawgs
reviewed
Jun 10, 2022
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Member
|
Had to remove it as a Required workflow from the |
Member
Author
|
It's a really basic implementation. It should really be implemented as "do markdown changes exist? yes: run check, no: return green". |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow that will check the line length within Markdown documents in this project. It's possible we could migrate this to the common workflows repo, but I'm not clear if that is possible given how the tools in this workflow work. Anyone is welcome to do their own testing and move it if they determine it viable.
See https://github.com/stupid-org/md-lint/pull/1/files for an example of what a failed check looks like.
Checklist
npm run testandnpm run benchmarkand the Code of conduct