Skip to content

Fixed typo res.res to reply.res #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcollina merged 1 commit into from
Feb 15, 2020
Merged

Fixed typo res.res to reply.res #2099

mcollina merged 1 commit into from
Feb 15, 2020

Conversation

@sumeetkbhardwaj
Copy link
Contributor

@sumeetkbhardwaj sumeetkbhardwaj commented Feb 14, 2020 •
edited
Loading

There was a typo error in documentation in disableRequestLogging section.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@sumeetkbhardwaj
Fixed typo res.res to reply.res
c426c2f 
There was a typo error in documentation in **disableRequestLogging** section.
@sumeetkbhardwaj sumeetkbhardwaj mentioned this pull request Feb 14, 2020
Merged
4 tasks
jsumners
jsumners approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit da4c89d into fastify:master Feb 15, 2020
This was referenced Feb 20, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2020
Closed
This was referenced Apr 12, 2020
Merged
Merged
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Closed
@github-actions
Copy link

github-actions bot commented Feb 10, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sumeetkbhardwaj @mcollina @jsumners