Skip to content

Throws error if undefined status code is sent#2082

Merged
mcollina merged 1 commit intofastify:masterfrom
leorossi:bugfix/truncated-response-on-undefined-statuscode
Feb 13, 2020
Merged

Throws error if undefined status code is sent#2082
mcollina merged 1 commit intofastify:masterfrom
leorossi:bugfix/truncated-response-on-undefined-statuscode

Conversation

@leorossi
Copy link
Copy Markdown
Contributor

@leorossi leorossi commented Feb 5, 2020

When setting an undedined status code in reply, it will throw a new custom error message.

Fixes #2078

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Feb 7, 2020

ci is failing on Node 6.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm added v2.x Issue or pr related to Fastify v2 bugfix Issue or PR that should land as semver patch labels Feb 7, 2020
@leorossi leorossi force-pushed the bugfix/truncated-response-on-undefined-statuscode branch from 87704d4 to 8386175 Compare February 13, 2020 15:44
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncated error response when using reply.code(undefined)

4 participants