Update route generics to use object instead #1951
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmark(tests failing due to tsd - Can't expect type on a type intersection tsdjs/tsd#59)While working on the new documentation I realized that when defining generic properties for routes can be extremely repetitive, and exhaustive when only defining one of the 4 available generics (Body, Querystring, Params, Headers). For example:
In this example we only need to modify the
Querystringgeneric, but are required to pass in the precedingBodygeneric and the remainingParams,Headers, andContextgenerics.This PR merges the 4 generics related to the
requestobject into a single generic propertyRequestGeneric, allowing the developer to specify only the properties necessary using named properties. Thus, simplifying the previous example into:Something going on in the tsd library we're using to test the type definitions is causing a previously passing test to fail so I have an issue opened to resolve that. We can consider this PR blocked until that is fixed.