Remove code from error name (v2.x) #1787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FastifyError.toString to display code in `console.log(error)`
delvedor
reviewed
Aug 5, 2019
Member
delvedor
left a comment
There was a problem hiding this comment.
As said by @mcollina, I agree that errors should be identified via the code property, but if someone is currently relying on the name property this will be a breaking change.
We are facing two options:
- release the breaking change and be ready to release a patch if we see that this is causing too many issues.
- close this pr, since this change will land in any case in
v3
I'm fine with either option.
👍 for merge it in master
😄 for postpone this to v3
Member
Author
|
@fastify/fastify see comment above for a vote ^ |
Member
|
It seems we are at a stall, maybe we should err for the safety case and wait for v3. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #1786 except targeting the
masterbranch.Checklist
npm run testandnpm run benchmark