feat: converted all the tap tests with node:test#739
Merged
Eomm merged 3 commits intofastify:masterfrom Sep 26, 2024
Merged
Conversation
Uzlopak
requested changes
Sep 17, 2024
Contributor
There was a problem hiding this comment.
Unfortunately not how we would like it.
Lets take from surrogate.test.js the first test case:
'use strict'
const test = require('tap').test
const validator = require('is-my-json-valid')
const build = require('..')
test('render a string with surrogate pairs as JSON:test 1', (t) => {
t.plan(2)
const schema = {
title: 'surrogate',
type: 'string'
}
const validate = validator(schema)
const stringify = build(schema)
const output = stringify('𝌆')
t.equal(output, '"𝌆"')
t.ok(validate(JSON.parse(output)), 'valid schema')
})You did:
'use strict'
const { describe } = require('node:test')
const { equal, ok } = require('node:assert')
const validator = require('is-my-json-valid')
const build = require('..')
describe('render a string with surrogate pairs as JSON:test 1', (t) => {
const schema = {
title: 'surrogate',
type: 'string'
}
const validate = validator(schema)
const stringify = build(schema)
const output = stringify('𝌆')
equal(output, '"𝌆"')
ok(validate(JSON.parse(output)), 'valid schema')
})what i expected:
'use strict'
const { test } = require('node:test')
const validator = require('is-my-json-valid')
const build = require('..')
test('render a string with surrogate pairs as JSON:test 1', (t) => {
t.plan(2)
const schema = {
title: 'surrogate',
type: 'string'
}
const validate = validator(schema)
const stringify = build(schema)
const output = stringify('𝌆')
t.assert.strictEqual(output, '"𝌆"')
t.assert.ok(validate(JSON.parse(output)), 'valid schema')
})Please revert and change accordingly. Thank you for your effort.
Contributor
Author
|
maaaaany changes 😄 it should be fine now! |
Uzlopak
approved these changes
Sep 17, 2024
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
Can somebody another review. I just scrolled down in my phone and just checked if my remark was implemented.
Eomm
requested changes
Sep 21, 2024
9e8fb31 to
e937674
Compare
Eomm
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taptonode:testandnode:asserttapdependency and related configuration filesChecklist
npm run testandnpm run benchmarkand the Code of conduct