Resolved Cannot convert a BigInt value to a number#723
Merged
jsumners merged 2 commits intofastify:masterfrom Jun 19, 2024
Merged
Resolved Cannot convert a BigInt value to a number#723jsumners merged 2 commits intofastify:masterfrom
jsumners merged 2 commits intofastify:masterfrom
Conversation
Signed-off-by: Camillo Positano <59197708+camillo-positano@users.noreply.github.com>
jsumners
reviewed
Jun 19, 2024
Member
jsumners
left a comment
There was a problem hiding this comment.
This will eventually get reverted without a test.
Exception thrown was Cannot convert a BigInt value to a number. This test verifies that it can convert a big int Signed-off-by: Camillo Positano <59197708+camillo-positano@users.noreply.github.com>
Contributor
Author
|
I added a test to make sure that the method asNumber is able to convert a BigInt value that i was using. It this enough or can i improve the test? |
jsumners
approved these changes
Jun 19, 2024
ivan-tymoshenko
approved these changes
Jun 19, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
i was working on a project for a client and was using Prisma as an ORM. In my schema i was using BigInt as a value and everything was working fine until i upgraded to 5.15 of fast-json-stringify.
I then went and digged into your commits and found that you changed from
Number(i)to+i.This change broke my project causing 'Cannot convert a BigInt value to a number' when returing a big int from the database, and now i have to stay on version prior to 5.15.
Therefore i created this pr to revert that line of code back to Number(i) and everything works fine.
Hope this helps.
Let me know if you need more details!
ps: if you see an identical pull request it was because i used the wrong account!